Add clone support#454
Merged
Merged
Conversation
This was referenced Jan 3, 2026
This was referenced Jan 5, 2026
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Svg.Skia deep cloning and clone coverage enhancements
Overview
This branch standardizes deep cloning across ShimSkiaSharp and Svg.Model, preserves shared-reference semantics where appropriate, and adds comprehensive clone coverage tests. It introduces a formal clone contract via interfaces, extends drawable cloning across the Svg.Model object graph, and adds unit test projects and coverage checks to validate behavior.
Key changes
IDeepCloneable<T>andDeepClone()implementations for records and classes, including SKDrawable support.Behavior changes
Tests
dotnet test tests/ShimSkiaSharp.UnitTests/ShimSkiaSharp.UnitTests.csproj -c Releasetests/ShimSkiaSharp.UnitTests/SKPathTests.cs.dotnet test tests/Svg.Model.UnitTests/Svg.Model.UnitTests.csproj -c Release