Dependencies issue fix#397
Merged
Merged
Conversation
Owner
|
Did you check if it works with SkiaSharp 3.0 ? |
Owner
|
Why I would care about: SkiaSharp.NativeAssets.Linux in Svg.Controls.Skia.Avalonia its user responsibility to add platform specific dependencies, this is unnecessary dependency |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses dependency conflicts between SkiaSharp versions used by different packages in the project. The main issue is that Avalonia.Skia uses SkiaSharp version 2.88.9 while Svg.Controls.Skia.Avalonia was using version 3.116.1, creating compatibility problems.
- Consolidates dependency management by replacing separate SkiaSharp.props and Avalonia.props imports with a unified Avalonia.Skia.props
- Updates SkiaSharp API usage to maintain compatibility with the older version 2.88.9
- Removes redundant import statements across multiple project files
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Svg.Skia/Svg.Skia.csproj | Replaces SkiaSharp-specific imports with unified Avalonia.Skia.props |
| src/Svg.Skia/SkiaModel.cs | Updates API call to use older SkiaSharp version's filtering method |
| src/Svg.Controls.Skia.Avalonia/Svg.Controls.Skia.Avalonia.csproj | Removes separate SkiaSharp and Avalonia imports, keeps unified Avalonia.Skia.props |
| src/Svg.Controls.Avalonia/Svg.Controls.Avalonia.csproj | Removes commented-out import statements |
| src/Skia.Controls.Avalonia/Skia.Controls.Avalonia.csproj | Removes separate SkiaSharp and Avalonia imports, keeps unified Avalonia.Skia.props |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Aug 22, 2025
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem:
https://www.nuget.org/packages/Avalonia.Skia/11.3.3#dependencies-body-tab
SkiaSharp.NativeAssets.Linux (>= 2.88.9)
SkiaSharp.NativeAssets.WebAssembly (>= 2.88.9)
Svg.Controls.Skia.Avalonia has SkiaSharp version 3.116.1 https://www.nuget.org/packages/Svg.Controls.Skia.Avalonia/11.3.0.2#dependencies-body-tab
To avoid these conflicts I suggest using the same SkiaSharp version as used Avalonia package.
As shown in this PR.
OR if you want to force a custom SkiaSharp version in the Svg.Controls.Skia.Avalonia package, you must care about
dependent assets:
SkiaSharp.NativeAssets.Linux
SkiaSharp.NativeAssets.Win32
SkiaSharp.NativeAssets.WebAssembly