Skip to content

Fix asset loader metrics fallback #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wieslawsoltes merged 2 commits into from
Jul 14, 2025
Merged

Fix asset loader metrics fallback #324

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd50c59
Avoid recursive filter application
wieslawsoltes Jul 14, 2025
55d4afb
Remove unnecessary metrics fallback
wieslawsoltes Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Svg.Model/Drawables/DrawableBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,14 +418,21 @@ public virtual void DebugDrawBounds(SKCanvas canvas)
| DrawAttributes.Opacity
| DrawAttributes.Filter;

// When a filter references 'SourceGraphic', we must draw the element
// without applying its filter again to avoid infinite recursion.
private const DrawAttributes FilterSourceInput =
DrawAttributes.Filter;

protected virtual void PostProcessChildren(SKRect? clip, SKMatrix totalMatrix)
{
}

SKPicture? IFilterSource.SourceGraphic(SKRect? clip)
{
PostProcessChildren(clip, SKMatrix.Identity);
return RecordGraphic(this, clip, DrawAttributes.None);
// Ignore the element's filter when rendering the source graphic so
// that filter primitives do not recursively re-enter filtering.
return RecordGraphic(this, clip, FilterSourceInput);
}

SKPicture? IFilterSource.BackgroundImage(SKRect? clip) => RecordBackground(this, clip, FilterBackgroundInput);
Expand Down
Loading