Fix ToolDock GripMode Inheritance on Split#997
Merged
wieslawsoltes merged 3 commits intomasterfrom Jan 22, 2026
Merged
Conversation
Copy IsExpanded, AutoHide, and GripMode to new tool docks.
Cover split into a new tool dock.
This was referenced Feb 2, 2026
This was referenced Feb 9, 2026
This was referenced Feb 18, 2026
This was referenced Feb 25, 2026
This was referenced Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary: Fix ToolDock GripMode Inheritance on Split (Issue 868)
Summary
This change fixes an issue where a
ToolDockconfigured withGripMode = GripMode.AutoHidedid not consistently apply that setting to new tool docks created during split operations. When a tool is dragged to split a tool dock, the new dock now inheritsGripMode(and related tool-dock settings) from the original tool dock, ensuring consistent chrome behavior.Implementation Details
Propagate ToolDock Settings During Split
When
DockServicecreates a newToolDockinSplitToolDockable, the new dock now copies tool-dock settings from the most relevant source dock:ToolDock.The following properties are copied:
IsExpandedAutoHideGripModeThis ensures that dock chrome visibility and grip behavior are consistent for newly created tool docks.
Test Coverage
A new unit test validates that splitting a tool from a
ToolDockwithGripMode.AutoHideresults in a newToolDockthat also usesGripMode.AutoHide.Usage Notes
No API changes are required. Existing code that sets
ToolDock.GripModewill now behave consistently when users split tools:Tests
dotnet testFixes #868