Add CanDockAsDocument to IDockable#996
Merged
wieslawsoltes merged 4 commits intomasterfrom Jan 22, 2026
Merged
Conversation
This was referenced Feb 2, 2026
This was referenced Feb 9, 2026
This was referenced Feb 18, 2026
This was referenced Feb 25, 2026
This was referenced Mar 4, 2026
Closed
This was referenced Mar 16, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary: Add CanDockAsDocument
Summary
This change introduces
CanDockAsDocumentonIDockableto let dockables opt out of being docked as tabbed documents. The flag is enforced during docking validation and when invokingDockAsDocument, exposed in Avalonia UI bindings, and documented with tests to cover the expected behavior.Implementation Details
CanDockAsDocumenttoIDockableand all model base classes, with defaults set totrue.WithCanDockAsDocumentfor easy configuration.DockManagervalidation so dockables that opt out cannot dock intoIDocumentDockorIDocumenttargets.FactoryBase.DockAsDocumentso programmatic docking respects the flag.Key files:
src/Dock.Model/Core/IDockable.cssrc/Dock.Model/DockManager.cssrc/Dock.Model/FactoryBase.Dockable.cssrc/Dock.Model/FluentExtensions.cssrc/Dock.Model.Avalonia/Core/DockableBase.cssrc/Dock.Model.Avalonia/Json/AvaloniaDockSerializer.cssrc/Dock.Avalonia.Themes.Fluent/Controls/ToolChromeControl.axamlsrc/Dock.Avalonia.Themes.Fluent/Controls/ToolPinItemControl.axamlsrc/Dock.Avalonia.Themes.Fluent/Controls/ToolTabStripItem.axamlsrc/Dock.Avalonia.Diagnostics/Controls/DockableDebugView.axamlUsage
View model / code
Fluent configuration
Behavior notes
CanDockAsDocumentisfalse, docking intoIDocumentDockorIDocumenttargets is rejected.DockAsDocumentdoes nothing for dockables withCanDockAsDocument = false.Tests
Covered by new/updated tests:
tests/Dock.Avalonia.HeadlessTests/DockManagerTests.cstests/Dock.Avalonia.HeadlessTests/DockManagerDocumentTests.cstests/Dock.Avalonia.HeadlessTests/FactoryDockAsDocumentTests.cstests/Dock.Model.UnitTests/DockGroupValidationTests.csNotes
Fixes #902