Skip to content

Fix proportional dock save and restore#1093

Merged
wieslawsoltes merged 2 commits intowieslawsoltes:masterfrom
danwalmsley:fix/proportional-save-restore
Apr 24, 2026
Merged

Fix proportional dock save and restore#1093
wieslawsoltes merged 2 commits intowieslawsoltes:masterfrom
danwalmsley:fix/proportional-save-restore

Conversation

@danwalmsley
Copy link
Copy Markdown
Contributor

Summary
This change fixes proportional dock layout persistence so splitter-driven size changes are saved back into the dock model and restored correctly when the layout is reopened.

What changed
updated the proportional dock presenter binding so proportion values round-trip correctly between the UI container and the underlying dock model
removed the old code-behind hookup used to manage proportional bindings
simplified the implementation by relying on the XAML binding path instead of imperative container preparation logic
Why
When users resized proportional dock regions with the splitter, the updated proportions were not being restored reliably after reopening a tab or restarting the app. The UI sizing state was not consistently flowing back into the serialized layout model.

Result
splitter changes to proportional dock sizes are persisted
saved layouts restore the expected proportions on reopen/startup
the proportional dock implementation is smaller and easier to reason about
Testing
verified the proportional dock save/restore fix on the current branch
confirmed the relevant Dock-side change is limited to:
src/Dock.Avalonia.Themes.Fluent/Controls/ProportionalDockControl.axaml
src/Dock.Avalonia/Controls/ProportionalDockControl.axaml.cs

@wieslawsoltes
Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@wieslawsoltes wieslawsoltes merged commit dbe5d60 into wieslawsoltes:master Apr 24, 2026
4 checks passed
This was referenced Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants