Fix proportional dock save and restore#1093
Merged
wieslawsoltes merged 2 commits intowieslawsoltes:masterfrom Apr 24, 2026
Merged
Fix proportional dock save and restore#1093wieslawsoltes merged 2 commits intowieslawsoltes:masterfrom
wieslawsoltes merged 2 commits intowieslawsoltes:masterfrom
Conversation
Owner
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes proportional dock layout persistence so splitter-driven size changes are saved back into the dock model and restored correctly when the layout is reopened.
What changed
updated the proportional dock presenter binding so proportion values round-trip correctly between the UI container and the underlying dock model
removed the old code-behind hookup used to manage proportional bindings
simplified the implementation by relying on the XAML binding path instead of imperative container preparation logic
Why
When users resized proportional dock regions with the splitter, the updated proportions were not being restored reliably after reopening a tab or restarting the app. The UI sizing state was not consistently flowing back into the serialized layout model.
Result
splitter changes to proportional dock sizes are persisted
saved layouts restore the expected proportions on reopen/startup
the proportional dock implementation is smaller and easier to reason about
Testing
verified the proportional dock save/restore fix on the current branch
confirmed the relevant Dock-side change is limited to:
src/Dock.Avalonia.Themes.Fluent/Controls/ProportionalDockControl.axaml
src/Dock.Avalonia/Controls/ProportionalDockControl.axaml.cs