Migrate Dock to Avalonia 12.0.0#1083
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 348e2fa9b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…c1-migration # Conflicts: # Directory.Build.props # src/Dock.Avalonia.Themes.Fluent/Controls/HostWindow.axaml # tests/Dock.Avalonia.HeadlessTests/HostWindowThemeChangeTests.cs
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af8dc5b761
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/Dock.Avalonia.Themes.Browser/Styles/Controls/HostWindow.axaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d346c5bcd1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Avalonia 12.0.0 Migration
Overview
This PR migrates Dock from Avalonia 11.x to Avalonia
12.0.0and updates the supporting stack so the libraries, themes, tests, docs, and samples work on the final stable API surface.What Changed
1. Package and release metadata
12.0.0.VersionPrefixat12.0.0and clearedVersionSuffixfor the stable release.Avalonia.ReactiveUItoReactiveUI.Avalonia.2. Runtime and theme migration
HostWindowchrome handling to the Avalonia 12 window-decoration APIs.WindowDrawnDecorationsresources and aligned host window templates with Avalonia 12 behavior.BorderOnly.3. Top-level, drag, and hit-testing fixes
GetVisualRoot()assumptions with Avalonia 12-compatible top-level and presentation-source access.4. Samples, docs, and stable follow-ups
master, aligned the deferred-content sample and package with the stable Avalonia 12 lane:DockDeferredContentSampleDock.Controls.DeferredContentControltonet8.0andnet10.0Behavior Notes
Floating host windows
Dock target / selector behavior
Testing
Verified with:
Results:
Reviewer Guide
Suggested review order:
Directory.Packages.props,Directory.Build.props,build/src/Dock.Avalonia/Controls/HostWindow.axaml.cssrc/Dock.Avalonia.Themes.Fluent/Controls/HostWindow.axamlsrc/Dock.Avalonia.Themes.Fluent/Controls/WindowDrawnDecorations.axamlsrc/Dock.Avalonia/Internal/AdornerHelper.cssrc/Dock.Avalonia/Internal/DockHelpers.cssrc/Dock.Avalonia/Controls/DockTargetBase.cssrc/Dock.Controls.DeferredContentControl/andsamples/DockDeferredContentSample/tests/Dock.Avalonia.HeadlessTests/samples/