Dock Capability Policy Integration#1046
Merged
wieslawsoltes merged 4 commits intomasterfrom Feb 11, 2026
Merged
Conversation
This was referenced Feb 16, 2026
Closed
This was referenced Feb 23, 2026
Closed
This was referenced Mar 2, 2026
Closed
This was referenced Mar 6, 2026
Closed
This was referenced Mar 16, 2026
Closed
This was referenced Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary: Dock Capability Policy Integration
Branch
feature/capability-policy-integrationGoal
Implement a full capability-policy system for Dock, including:
Commit Breakdown
bf2246b00feat(model): add dock capability policy contracts and resolver9b8e78c19feat(avalonia): enforce capability policy in controls and themes710b32f68test: add capability policy coverage across model and headless suites8e530f8f6docs(samples): add capability policy guidance and reactive sample editorDetailed Changes
1) Model/Core capability contract and precedence
Added new capability abstraction and evaluation model:
src/Dock.Model/Core/DockCapability.cssrc/Dock.Model/Core/DockCapabilityValueSource.cssrc/Dock.Model/Core/DockCapabilityEvaluation.cssrc/Dock.Model/Core/IDockCapabilityPolicy.cssrc/Dock.Model/Core/DockCapabilityPolicy.cssrc/Dock.Model/Core/DockCapabilityOverrides.cssrc/Dock.Model/DockCapabilityResolver.csExtended key model contracts:
src/Dock.Model/Core/IDockable.cssrc/Dock.Model/Core/IDock.cssrc/Dock.Model/Core/IDockManager.cssrc/Dock.Model/Controls/IRootDock.csIntegrated policy state into all model variants (Avalonia/INPC/MVVM/Prism/ReactiveProperty/ReactiveUI/Caliburn):
DockBasegets dock-level policy property.DockableBasegets dockable override property.RootDockgets root policy property.Factory and manager integration:
src/Dock.Model/FactoryBase.Dockable.cssrc/Dock.Model/DockManager.cssrc/Dock.Model/DockService.csEffective capability resolution precedence implemented as:
CanClose,CanPin, etc.)The resolver returns diagnostics (
DockCapabilityEvaluation) explaining both effective value and source.2) Avalonia runtime enforcement and reactive UI capability behavior
Added capability converter support:
src/Dock.Avalonia/Converters/DockCapabilityConverters.csIValueConverterandIMultiValueConverterusage.*MultiConvertersingletons forMultiBindingscenarios.Runtime interaction paths now enforce effective capabilities instead of only raw flags:
src/Dock.Avalonia/Controls/DocumentTabStripItem.axaml.cssrc/Dock.Avalonia/Controls/ToolTabStripItem.axaml.cssrc/Dock.Avalonia/Controls/MdiDocumentWindow.axaml.cssrc/Dock.Avalonia/Controls/ManagedDockableBase.cssrc/Dock.Avalonia/Controls/ManagedWindowDock.cssrc/Dock.Avalonia/Internal/DockControlState.cssrc/Dock.Avalonia/Internal/DockManagerState.cssrc/Dock.Avalonia/Internal/HostWindowState.cssrc/Dock.Avalonia/Internal/ManagedHostWindowState.csAutomation peers updated to surface capability-constrained behavior in automation interactions:
src/Dock.Avalonia/Automation/Peers/DocumentTabStripItemAutomationPeer.cssrc/Dock.Avalonia/Automation/Peers/ToolTabStripItemAutomationPeer.cssrc/Dock.Avalonia/Automation/Peers/ToolPinItemControlAutomationPeer.cssrc/Dock.Avalonia/Automation/Peers/ToolChromeControlAutomationPeer.cssrc/Dock.Avalonia/Automation/Peers/MdiDocumentWindowAutomationPeer.cs3) Fluent theme capability binding overhaul
Updated Fluent control templates/menus to bind visibility/drag/drop behavior through effective capability multi-bindings:
src/Dock.Avalonia.Themes.Fluent/Controls/DocumentControl.axamlsrc/Dock.Avalonia.Themes.Fluent/Controls/DocumentTabStripItem.axamlsrc/Dock.Avalonia.Themes.Fluent/Controls/MdiDocumentWindow.axamlsrc/Dock.Avalonia.Themes.Fluent/Controls/ToolChromeControl.axamlsrc/Dock.Avalonia.Themes.Fluent/Controls/ToolPinItemControl.axamlsrc/Dock.Avalonia.Themes.Fluent/Controls/ToolTabStripItem.axamlImportant fix included:
ToolChromeControldrag/drop policy trigger paths now observeIToolDockpolicy context (not root owner policy), matching resolver semantics and ensuring reactive updates track the correct policy object.4) Test coverage
Model tests added:
tests/Dock.Model.UnitTests/DockCapabilityPolicyTests.cstests/Dock.Model.UnitTests/DockCapabilityResolverTests.cstests/Dock.Model.UnitTests/DockManagerCapabilityPolicyTests.cstests/Dock.Model.UnitTests/DockServiceCapabilityPolicyTests.cstests/Dock.Model.UnitTests/DockGroupValidationTests.cs(updated)Avalonia headless tests added:
tests/Dock.Avalonia.HeadlessTests/DockCapabilityConvertersTests.cstests/Dock.Avalonia.HeadlessTests/DockCapabilityBindingUpdateTests.cstests/Dock.Avalonia.HeadlessTests/CapabilityPolicyFactoryTests.cstests/Dock.Avalonia.HeadlessTests/CapabilityPolicyThemeBindingTests.cstests/Dock.Avalonia.HeadlessTests/ManagedWindowParityTests.cs(updated)CapabilityPolicyThemeBindingTestsvalidates all new theme binding additions across both themes:DockFluentThemeDockSimpleTheme(linked controls)Covered controls include:
DocumentControlDocumentTabStripItemMdiDocumentWindowToolTabStripItemToolPinItemControlToolChromeControlThe tests verify policy transition behavior:
5) Sample updates
Enhanced reactive sample to exercise policy features:
samples/DockXamlReactiveUISample/ViewModels/CapabilityPolicyEditor.cssamples/DockXamlReactiveUISample/ViewModels/MainWindowViewModel.cssamples/DockXamlReactiveUISample/Views/MainWindow.axamlsamples/DockXamlReactiveUISample/Infrastructure/SampleDockItemContainerGenerator.cssamples/DockXamlReactiveUISample/Models/DocumentItem.cssamples/DockXamlReactiveUISample/Models/ToolItem.csSample now exposes and edits root/dock/dockable capability policy state to validate precedence in UI.
6) Documentation updates
Added new policy-focused article and linked into docs navigation:
docfx/articles/dock-capability-policies.mddocfx/articles/dock-dockable-properties.mddocfx/articles/dock-docking-constraints.mddocfx/articles/dock-itemssource.mddocfx/articles/dock-manager-guide.mddocfx/articles/toc.ymlDocs now explain:
Validation Run
Executed and passed:
dotnet test tests/Dock.Avalonia.HeadlessTests/Dock.Avalonia.HeadlessTests.csproj -v minimaldotnet test tests/Dock.Model.UnitTests/Dock.Model.UnitTests.csproj -v minimaldotnet test Dock.slnx --no-build -v minimalCompatibility Notes
IValueConverterfields, with additional dedicated multi-binding fields.