Skip to content

fix: support starlette 0.33 #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maartenbreddels merged 1 commit into from
Dec 8, 2023
Merged

fix: support starlette 0.33 #413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion solara/server/starlette.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,8 @@ async def root(request: Request, fullpath: str = ""):
if settings.main.root_path is None:
# use the default root path from the app, which seems to also include the path
# if we are mounted under a path
root_path = request.scope.get("root_path", "")
scope = request.scope
root_path = scope.get("route_root_path", scope.get("root_path", ""))
logger.debug("root_path: %s", root_path)
# or use the script-name header, for instance when running under a reverse proxy
script_name = request.headers.get("script-name")
Expand Down