-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#926 Use Webjars for JQueryUI #927
#926 Use Webjars for JQueryUI #927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also
- use
*.css
from webjars for thisbase
theme wicket-jquery-ui-parent/wicket-jquery-ui-themes/theme-base/src/main/java/com/googlecode/wicket/jquery/ui/theme/Initializer.java WicketWebjars.install(this);
should be added towicket-jquery-ui-parent/wicket-jquery-ui-samples/src/main/java/com/googlecode/wicket/jquery/ui/samples/SampleApplication.java
, otherwise examples will not work ....
...ff-jquery-ui/src/main/java/org/wicketstuff/jquery/ui/resource/JQueryUIResourceReference.java
Outdated
Show resolved
Hide resolved
...ketstuff-jquery-ui-theme-base/src/main/java/org/wicketstuff/jquery/ui/theme/Initializer.java
Show resolved
Hide resolved
Hello @martin-g, It seems this PR breaks samples Webjars are being used from so we got
due to What can be done here? |
As error message suggests we need to add 'WicketWebjars.install()' to the respective WebApplication#init() |
Oh, now I see the text after the stacktrace. |
Works as expected! Thanks a million @martin-g :) |
@solomax so how did you solve this? |
I think this change needs to be made in the initializer of all of the themes separately. |
I also thought so But I believe right now it's not necessary due to the fact the only theme uses webjar so far :) |
I have created a PR #934 to resolve this |
Resolves #926