-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to use custom IV in AES/GCM #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and sorry for long delay!
Looks good!
I've started tests, but I do see, that klib
dump is for some reason missing, have you run apiDump
?
Also, it would be nice to add additional testing of custom IV in compatibility test like it was added here: fcd13f5#diff-95b13bb1e657d46d67c27f687519118156c333f974d16a88d646cc6f18d9a6e7
Hey @morki, are you still willing to finish PR? Or I could finish it? The reason I'm asking, is that I do have some changes to be merged which will have conflicts. |
Hi @whyoleg, I was planning to create tests etc, but I am on vacations now, so I can not finnish it for about 3 weeks now. If you want and have time, you can finish this before the changes. If not, that is ok too, I can start from stratch after your changes :) |
Hi @whyoleg, is it somewhat "stable" now to start to do this PR again from scratch or would you suggest to delay it a bit more due to heavy changes still in progress? |
Hey! I've decided to postpone big changes for some future release as I was not really happy with the API shape. |
Hey @morki are you still willing to work on this PR? I'm planning to do a release by the end of September and wanted to include this. |
Hi @whyoleg, yes I am, will try to finnish it in a couple of days :) |
I think it is ready for what I can do for it. But it has one problem with tests. WebCrypto and OpenSSL providers are ok, but JDK are throwing I tried but I really don't know how to solve it. Can you please take a look @whyoleg? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very sorry again for the long delay, I was not very active last week with my OpenSource projects :(
The changes look fine, thank you! A bit small fixes and we are ready to merge!
I was able to find workaround for JDK GCM IV reuse issue!
Also, could you please run apiDump
task locally? Without it the CI will fail
cryptography-providers-tests/src/commonMain/kotlin/compatibility/AesGcmCompatibilityTest.kt
Outdated
Show resolved
Hide resolved
cryptography-providers-tests/src/commonMain/kotlin/compatibility/AesGcmCompatibilityTest.kt
Outdated
Show resolved
Hide resolved
Ou, and the
|
Hm, I see. It needs macOS :) |
I run it and it works, thank you for the guidance :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once more, thanks for contribution!
CI is green!
See #36