Adapt to new error location type #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coq/coq#19040 changes the way error locations are reported in the XML protocol. Specifically, it replaces the `loc_s` and `loc_e` attributes of the `fail` result with an optional `Loc.t` field. If I understand correctly, the `start` and `stop` fields contain the same byte offsets as the old `loc_s` and `loc_e`, so it's enough to just extract and return those.
Rixxc
pushed a commit
to Rixxc/Coqtail
that referenced
this pull request
Jul 2, 2024
coq/coq#19040 changes the way error locations are reported in the XML protocol. Specifically, it replaces the `loc_s` and `loc_e` attributes of the `fail` result with an optional `Loc.t` field. If I understand correctly, the `start` and `stop` fields contain the same byte offsets as the old `loc_s` and `loc_e`, so it's enough to just extract and return those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coq/coq#19040 changes the way error locations are reported in the XML protocol. Specifically, it replaces the
loc_sandloc_eattributes of thefailresult with an optionalLoc.tfield. If I understand correctly, thestartandstopfields contain the same byte offsets as the oldloc_sandloc_e, so it's enough to just extract and return those.