Skip to content

fix(generators): Resolve duplicate type definitions in MessageJsonContext#86

Merged
philcarbone merged 3 commits into
developfrom
feature/json-context-unique-identifiers
Feb 7, 2026
Merged

fix(generators): Resolve duplicate type definitions in MessageJsonContext#86
philcarbone merged 3 commits into
developfrom
feature/json-context-unique-identifiers

Conversation

@philcarbone
Copy link
Copy Markdown
Contributor

Summary

  • Fix duplicate type definition errors when multiple message types share the same simple name in different namespaces
  • Add UniqueIdentifier computed property to JsonMessageTypeInfo and ListTypeInfo records
  • Update generator to use fully qualified unique identifiers for field and method naming

Test plan

  • Added test Generator_WithSameSimpleNameInDifferentNamespaces_GeneratesUniqueIdentifiersAsync
  • All 10,468 existing tests pass
  • Verified generated code compiles without duplicate identifier errors

🤖 Generated with Claude Code

philcarbone and others added 3 commits February 2, 2026 20:23
Configure Dependabot to create PRs against the develop branch instead
of main, following GitFlow branching strategy.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
…text

When multiple message types share the same simple name in different
namespaces (e.g., MyApp.Commands.StartCommand and MyApp.Events.StartCommand),
the generator now uses unique identifiers derived from fully qualified names
instead of simple names for field and method naming.

- Add UniqueIdentifier computed property to JsonMessageTypeInfo
- Add ElementUniqueIdentifier computed property to ListTypeInfo
- Update snippets to use __UNIQUE_IDENTIFIER__ placeholders
- Update generator to use UniqueIdentifier for all naming

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 7, 2026

📦 Version Information: 0.4.0-pr86.64

Property Value
SemVer 0.4.0-pr86.64
Full SemVer 0.4.0-pr86.64
Pre-release pr86.64

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@philcarbone philcarbone merged commit a87f8d9 into develop Feb 7, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant