Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override the default value of editor.find.seedSearchStringFromSelection via the configurationDefaults contribution point #1766

Merged
merged 3 commits into from
Nov 12, 2023

Conversation

whitphx
Copy link
Owner

@whitphx whitphx commented Nov 12, 2023

configurationDefaults can override even the default value of other registered config.

https://github.com/microsoft/vscode-docs/blob/32c13b36b370c1e579888a7e5a6d5cc7e8e7b5ff/release-notes/v1_63.md?plain=1#L499

This feature is available since 1.63, so we don't have to update the engines field of the package.json of this extension.

Resolves #107

@whitphx whitphx marked this pull request as ready for review November 12, 2023 14:58
@whitphx whitphx force-pushed the feature/override-seed-search-string-config branch from 823c2dd to fce9405 Compare November 12, 2023 15:23
@whitphx whitphx merged commit 9ff6de0 into main Nov 12, 2023
6 checks passed
@whitphx whitphx deleted the feature/override-seed-search-string-config branch November 12, 2023 15:41
whitphx added a commit that referenced this pull request Nov 12, 2023
…omSelection` via the `configurationDefaults` contribution point (#1766)"

This reverts commit 9ff6de0.
whitphx added a commit that referenced this pull request Nov 12, 2023
…omSelection` via the `configurationDefaults` contribution point (#1766)" (#1768)

This reverts commit 9ff6de0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resuming incremental search replaces old search with word at current location
1 participant