Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dune: add dependency to unix library #24

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

psafont
Copy link
Contributor

@psafont psafont commented Nov 21, 2023

I've been getting this error without this when trying to use the library:

### output ###
# (cd _build/default && /home/paus/.local/share/opam/toolstack-local-no-async/bin/ocamlopt.opt -w -40 -w -39-6@5 -g -o ocaml/xapi-storage-script/main.exe /home/paus/.local/share/opam/toolstack-local-no-async/lib/base/base_internalhash_types/base_internalhash_types.cmxa -I /home/paus/.local/share/opam/toolstack-local-no-async/lib/base/base_internalhash_types /home/paus/.local/share/opam/toolstac[...]
# File "_none_", line 1:
# Error: No implementations provided for the following modules:
#          Unix referenced from /home/paus/.local/share/opam/toolstack-local-no-async/lib/inotify/inotify.cmxa(Inotify)

And this seems to be an easy enough fix, but I don't know whether I'm using it wrong

I'll be glad to add some missing dependency on my side. unix is already present in the dune dependency list of the binary, and adding base-unix to the opam dependency list doesn't fix it. If anybody is interested in looking into this, the branch that causes this is in xapi-project/xen-api@master...psafont:xen-api:no-async

This is needed because it's not part of the standard library in newer
distributions

Signed-off-by: Pau Ruiz Safont <[email protected]>
@c-cube c-cube merged commit a1f60f5 into whitequark:master Nov 21, 2023
3 checks passed
@c-cube
Copy link
Collaborator

c-cube commented Nov 21, 2023

Thank you! :)

@psafont psafont deleted the unix branch November 22, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants