Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the $maxPerPage and $currentPage params to the constructor #198

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yjv
Copy link

@yjv yjv commented Jan 18, 2016

this allows you the instaciate the PagerFanta instance all ready to go if you are already on a different page or you want a different max per page

@stof
Copy link
Contributor

stof commented Mar 23, 2016

This misses the validation of the values which is applied by setters.

and this is also missing tests covering this API

@Koc
Copy link

Koc commented Nov 27, 2017

now checks added. Can we merge? @sampart @stof

@sampart
Copy link
Collaborator

sampart commented Nov 27, 2017

@Koc Thanks for this. I can see that you've switched to using the setters which is great, but I think you still need to add tests as @stof mentioned please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants