Fixed parsing of values with narrow non-breaking spaces

whitecube · Dec 31, 2021 · a73bb01 · a73bb01
1 parent c9bf471
commit a73bb01
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/Parser.php b/src/Parser.php
@@ -39,7 +39,7 @@ public function __construct($value)
      */
     public function extractValue()
     {
-        $string = str_replace([',', ' '], ['.', ''], $this->original);
+        $string = str_replace([',', ' ', ' '], ['.', '', ''], $this->original);
 
         preg_match('/^[^-\.\d]*(\-?\d+(?:\.\d+)?)[^\d]*$/', $string, $matches);
 

diff --git a/tests/Unit/ParsesMonetaryStringsTest.php b/tests/Unit/ParsesMonetaryStringsTest.php
@@ -2,7 +2,6 @@
 
 namespace Tests\Unit;
 
-use Brick\Money\Money;
 use Whitecube\Price\Price;
 
 it('parses decimal (point) currency values', function() {
@@ -37,3 +36,8 @@
     expect(Price::parse('foo', 'EUR')->__toString())->toBe('EUR 0.00');
     expect(Price::parse('bar 6.50', 'EUR')->__toString())->toBe('EUR 6.50');
 });
+
+it('parses values with both narrow non-breaking and regular spaces', function() {
+    expect(Price::parse('1 234,56', 'EUR')->__toString())->toBe('EUR 1234.56');
+    expect(Price::parse('1 234,56', 'EUR')->__toString())->toBe('EUR 1234.56');
+});