Updated PriceAmendable using RationalMoney

whitecube · Sep 14, 2024 · a4cb67a · a4cb67a
1 parent d689fd4
commit a4cb67a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 15 deletions.
diff --git a/src/PriceAmendable.php b/src/PriceAmendable.php
@@ -2,7 +2,7 @@
 
 namespace Whitecube\Price;
 
-use Brick\Money\AbstractMoney;
+use Brick\Money\RationalMoney;
 
 interface PriceAmendable
 {
@@ -35,13 +35,6 @@ public function appliesAfterVat(): bool;
 
     /**
      * Apply the modifier on the given Money instance
-     *
-     * @param \Brick\Money\AbstractMoney $build
-     * @param float $units
-     * @param bool $perUnit
-     * @param null|\Brick\Money\AbstractMoney $exclusive
-     * @param null|\Whitecube\Price\Vat $vat
-     * @return null|\Brick\Money\AbstractMoney
      */
-    public function apply(AbstractMoney $build, float $units, bool $perUnit, AbstractMoney $exclusive = null, Vat $vat = null) : ?AbstractMoney;
+    public function apply(RationalMoney $build, float $units, bool $perUnit, RationalMoney $exclusive = null, Vat $vat = null) : ?RationalMoney;
 }
diff --git a/tests/Fixtures/AfterVatAmendableModifier.php b/tests/Fixtures/AfterVatAmendableModifier.php
@@ -6,7 +6,7 @@
 use Brick\Math\RoundingMode;
 use Whitecube\Price\Vat;
 use Whitecube\Price\PriceAmendable;
-use Brick\Money\AbstractMoney;
+use Brick\Money\RationalMoney;
 
 class AfterVatAmendableModifier implements PriceAmendable
 {
@@ -62,7 +62,7 @@ public function appliesAfterVat(): bool
     /**
      * Apply the modifier on the given Money instance
      */
-    public function apply(AbstractMoney $build, $units, $perUnit, AbstractMoney $exclusive = null, Vat $vat = null) : ?AbstractMoney
+    public function apply(RationalMoney $build, $units, $perUnit, RationalMoney $exclusive = null, Vat $vat = null) : ?RationalMoney
     {
         $tax = Money::ofMinor(100, 'EUR');
 

diff --git a/tests/Fixtures/AmendableModifier.php b/tests/Fixtures/AmendableModifier.php
@@ -5,7 +5,7 @@
 use Brick\Math\RoundingMode;
 use Whitecube\Price\Vat;
 use Whitecube\Price\PriceAmendable;
-use Brick\Money\AbstractMoney;
+use Brick\Money\RationalMoney;
 
 class AmendableModifier implements PriceAmendable
 {
@@ -61,7 +61,7 @@ public function appliesAfterVat(): bool
     /**
      * Apply the modifier on the given Money instance
      */
-    public function apply(AbstractMoney $build, $units, $perUnit, AbstractMoney $exclusive = null, Vat $vat = null) : ?AbstractMoney
+    public function apply(RationalMoney $build, $units, $perUnit, RationalMoney $exclusive = null, Vat $vat = null) : ?RationalMoney
     {
         return $build->multipliedBy(1.25, RoundingMode::HALF_UP);
     }

diff --git a/tests/Fixtures/CustomAmendableModifier.php b/tests/Fixtures/CustomAmendableModifier.php
@@ -6,7 +6,7 @@
 use Brick\Math\RoundingMode;
 use Whitecube\Price\Vat;
 use Whitecube\Price\PriceAmendable;
-use Brick\Money\AbstractMoney;
+use Brick\Money\RationalMoney;
 
 class CustomAmendableModifier implements PriceAmendable
 {
@@ -75,7 +75,7 @@ public function appliesAfterVat(): bool
     /**
      * Apply the modifier on the given Money instance
      */
-    public function apply(AbstractMoney $build, $units, $perUnit, AbstractMoney $exclusive = null, Vat $vat = null) : ?AbstractMoney
+    public function apply(RationalMoney $build, $units, $perUnit, RationalMoney $exclusive = null, Vat $vat = null) : ?RationalMoney
     {
         if($perUnit) {
             return $build->plus($this->tax);