-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/removable files #291
base: master
Are you sure you want to change the base?
Conversation
Seems like the limit issues were indeed fixed. Though now my PR is in conflict, I'll fix it asap. |
@Nyratas The PR is up to date ! |
@mrdj07 Thanks for taking my PR and improving it so much! @Nyratas Any idea when this PR could get merged? |
After my lastest merge I had a bad conflict resolution resulting in an infinite loop, it's now fixed. |
@Nyratas This is quite a big issue for us currently. Could you spend sometime reviewing this PR please? |
Any information on when this PR going to get merged? |
@Nyratas @voidgraphics Please review this PR. If have no time or are you're no longer willing to maintain this, then please pass it over to someone who can. |
@chrisneal We're trying to do that -> #326 |
…ontent into feature/removable-files
Updated |
Sorry for the wait on this, I will do my best to get to it this week. Thanks again for submitting this @mrdj07 |
…ed-layout Use depended fields
I needed to fix the remove image problem. I had in mind a solution of flattening the fields of the layout in order to let the Deletion Controller do it's job, but this pull request had it laid down pretty nicely.
I based my branch from master, cleaned up some stuff I found unnecessary in the initial PR, then found the following issues and fixed them:
I also reformatted all of the PHP files in PSR-2.