Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ServiceAddress by libsignal_protocol::ServiceId #334

Merged
merged 13 commits into from
Nov 5, 2024

Conversation

gferon
Copy link
Collaborator

@gferon gferon commented Oct 18, 2024

I hid a bunch of mistakes in there just to check if @rubdos is paying attention (jk, I think it should be fine).

This definitely changes some things, like in some cases when preparing protos, you would get the prefixed service_id_string for PNI (which was the raw UUID before). I'm pretty sure it didn't use to work correctly.

Thank you for reading.

@gferon gferon requested review from direc85 and rubdos October 18, 2024 15:43
Copy link
Member

@rubdos rubdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The strong types for Aci and Pni are awesome! Clippy has a useful suggestion too ;-)

src/account_manager.rs Outdated Show resolved Hide resolved
src/profile_service.rs Show resolved Hide resolved
src/push_service/keys.rs Outdated Show resolved Hide resolved
src/push_service/keys.rs Outdated Show resolved Hide resolved
src/push_service/profile.rs Show resolved Hide resolved
src/sender.rs Show resolved Hide resolved
src/sender.rs Show resolved Hide resolved
src/sender.rs Show resolved Hide resolved
src/sender.rs Show resolved Hide resolved
src/sender.rs Show resolved Hide resolved
src/sender.rs Outdated Show resolved Hide resolved
@gferon gferon requested a review from rubdos November 3, 2024 20:53
src/account_manager.rs Outdated Show resolved Hide resolved
src/cipher.rs Outdated Show resolved Hide resolved
src/envelope.rs Show resolved Hide resolved
src/sender.rs Show resolved Hide resolved
src/sender.rs Show resolved Hide resolved
src/service_address.rs Show resolved Hide resolved
@gferon
Copy link
Collaborator Author

gferon commented Nov 5, 2024

I think this is ready to 🚢

Regarding your suggestions to use recipent = %recipient.service_id_string(), I'm not sure I exactly get it, because this is the impl of tracing::Value for String: https://docs.rs/tracing-core/0.1.32/src/tracing_core/field.rs.html#632 which means we don't need to call the fmt::Display wrapper one.

@gferon gferon requested a review from rubdos November 5, 2024 10:14
@rubdos rubdos enabled auto-merge November 5, 2024 10:15
@rubdos rubdos merged commit f4313db into main Nov 5, 2024
6 of 7 checks passed
@rubdos rubdos deleted the service-address-no-more branch November 5, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants