Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #328
The other member decryption functions are ACI-only (which makes sense). I double-checked this.
@gferon, @boxdot, I have removed
Serialize
andDeserialize
bounds on some structs. These were in place because Presage stores those structs directly in its database, but I don't think that is correct behavior.libsignal-service
exposes those structs without any forward or backward compatibility guarantees, as illustrated in here: theuuid
field is dropped in favor of the service_id field. Migration should be handled by the storage backend. Same reasoning goes for #324.