Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement profile avatar retention #180

Merged
merged 1 commit into from
Nov 13, 2022
Merged

Implement profile avatar retention #180

merged 1 commit into from
Nov 13, 2022

Conversation

rubdos
Copy link
Member

@rubdos rubdos commented Nov 11, 2022

Will test now.

@rubdos
Copy link
Member Author

rubdos commented Nov 11, 2022

This only works after Rust 1.53, so I'm desugaring the or-patterns for now.

@rubdos
Copy link
Member Author

rubdos commented Nov 11, 2022

This seems to work well.

@rubdos rubdos requested a review from gferon November 11, 2022 09:32
Copy link
Collaborator

@gferon gferon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm only starting to think that we should think twice before adding more primitive arguments to our function and maybe introduce types so we can add variants later, but here it's perfectly fine 👍🏼🥳

@rubdos
Copy link
Member Author

rubdos commented Nov 13, 2022

LGTM! I'm only starting to think that we should think twice before adding more primitive arguments to our function and maybe introduce types so we can add variants later, but here it's perfectly fine 👍🏼partying_face

I agree. In this case, it makes the methods very Rusty, I feel.

@rubdos rubdos merged commit 43e0073 into master Nov 13, 2022
@rubdos rubdos deleted the avatar-retention branch November 13, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants