More async tool fixes (microsoft#1204)

* tool_responses fixes * [] is false
whiskyboy · Jan 11, 2024 · e7ccf5b · e7ccf5b
1 parent 622a291
commit e7ccf5b
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/autogen/agentchat/conversable_agent.py b/autogen/agentchat/conversable_agent.py
@@ -871,7 +871,7 @@ def generate_tool_calls_reply(
                     "content": func_return.get("content", ""),
                 }
             )
-        if len(tool_returns) > 0:
+        if tool_returns:
             return True, {
                 "role": "tool",
                 "tool_responses": tool_returns,
@@ -907,14 +907,12 @@ async def a_generate_tool_calls_reply(
             func = self._function_map.get(tool_call.get("function", {}).get("name", None), None)
             if func and asyncio.coroutines.iscoroutinefunction(func):
                 async_tool_calls.append(self._a_execute_tool_call(tool_call))
-        if len(async_tool_calls) > 0:
+        if async_tool_calls:
             tool_returns = await asyncio.gather(*async_tool_calls)
             return True, {
                 "role": "tool",
                 "tool_responses": tool_returns,
-                "content": "\n\n".join(
-                    [self._str_for_tool_response(tool_return["content"]) for tool_return in tool_returns]
-                ),
+                "content": "\n\n".join([self._str_for_tool_response(tool_return) for tool_return in tool_returns]),
             }
 
         return False, None
@@ -1128,7 +1126,10 @@ async def a_check_termination_and_human_reply(
                     ]
                 )
 
-            response = {"role": "user", "content": reply, "tool_responses": tool_returns}
+            response = {"role": "user", "content": reply}
+            if tool_returns:
+                response["tool_responses"] = tool_returns
+
             return True, response
 
         # increment the consecutive_auto_reply_counter