Minor cleanup #51
Merged
Minor cleanup #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Disabled git from converting newlines * Updated FetchTest to work under Windows
Co-authored-by: Jared Whiklo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #51 +/- ##
============================================
+ Coverage 88.61% 88.65% +0.03%
+ Complexity 491 485 -6
============================================
Files 7 7
Lines 1274 1260 -14
============================================
- Hits 1129 1117 -12
+ Misses 145 143 -2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Thanks for the help @jonasraoni (🥇 ), once donatj/mock-webserver#42 is merged then I can try re-enabling the Fetch tests too. |
|
Ok, I tested locally and it worked fine for me 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to using
/as file path separator internally for all OS'es.Fixes to get Windows to pass tests.