Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement removeBagInfoTagByValue #40

Merged
merged 6 commits into from
Mar 6, 2022
Merged

Implement removeBagInfoTagByValue #40

merged 6 commits into from
Mar 6, 2022

Conversation

whikloj
Copy link
Owner

@whikloj whikloj commented Mar 4, 2022

Do some changes for performance

Resolves: #31

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #40 (91991aa) into main (a6d3e28) will increase coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #40      +/-   ##
============================================
+ Coverage     88.55%   88.84%   +0.28%     
- Complexity      476      477       +1     
============================================
  Files             7        7              
  Lines          1241     1237       -4     
============================================
  Hits           1099     1099              
+ Misses          142      138       -4     
Impacted Files Coverage Δ
src/AbstractManifest.php 89.91% <100.00%> (+2.51%) ⬆️
src/Bag.php 86.10% <100.00%> (+0.11%) ⬆️
src/BagUtils.php 92.47% <100.00%> (-0.24%) ⬇️
src/Fetch.php 95.06% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6d3e28...91991aa. Read the comment docs.

@whikloj whikloj merged commit 500380e into main Mar 6, 2022
@whikloj whikloj deleted the issue-31 branch March 6, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove bag info tags by value
1 participant