Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[META] Ajust dfn-for of events on XHREventTarget #389

Merged
merged 3 commits into from
Jun 6, 2024
Merged

[META] Ajust dfn-for of events on XHREventTarget #389

merged 3 commits into from
Jun 6, 2024

Conversation

dontcallmedom
Copy link
Contributor

@dontcallmedom dontcallmedom commented Jun 5, 2024 •
edited by pr-preview bot
Loading

annevk
annevk reviewed Jun 5, 2024
View reviewed changes
Copy link
Member

@annevk annevk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently have many internal references like {{XMLHttpRequest/progress}} that this would break I think.

(I think the reason it doesn't fail CI is because CI runs against currently indexed terms.)

@dontcallmedom
Copy link
Contributor Author

oh, indeed - updated with the internal links hopefully fixed

annevk
annevk reviewed Jun 5, 2024
View reviewed changes
xhr.bs Outdated Show resolved Hide resolved
dontcallmedom
dontcallmedom commented Jun 5, 2024
View reviewed changes
xhr.bs Outdated Show resolved Hide resolved
@dontcallmedom dontcallmedom mentioned this pull request Jun 5, 2024
Open
@annevk @dontcallmedom
Update xhr.bs
68a29d4 
Co-authored-by: Dominique Hazael-Massieux <[email protected]>
@annevk annevk merged commit fd438ec into whatwg:main Jun 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dontcallmedom @annevk