Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a tracking vector image #64

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Add a tracking vector image #64

merged 2 commits into from
Jan 7, 2020

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Aug 28, 2017

Fixes whatwg/resources.whatwg.org#49

This is taken from whatwg/resources.whatwg.org#50. It's blocked on speced/bikeshed#964 (or at least I wanted to merge all fingerprint-related PRs at the same time).

@annevk
Copy link
Member

annevk commented Dec 19, 2017 •
edited
Loading

Should we also redirect images.whatwg.org/fingerprint.png to this? (And remove it there.)

@foolip
Copy link
Member

foolip commented Dec 19, 2017

There's a very large overlap between https://images.whatwg.org/ and https://html.spec.whatwg.org/images/, although whatwg/html@3cc2ca6 only happened on one side so there are some differences.

Do we want to use images.whatwg.org for anything going forward, or should it all be in either the spec's repo or resources.whatwg.org?

@annevk
Copy link
Member

annevk commented Dec 19, 2017

images is largely historical. I suspect a lot of old specifications hosted on whatwg.org still use it.

@npdoty npdoty mentioned this pull request Jul 31, 2018
Closed
@marcoscaceres marcoscaceres mentioned this pull request Aug 8, 2018
Open
@annevk
Copy link
Member

annevk commented Aug 28, 2019

To reply to the very old comments: I don't think we should do anything here with images.whatwg.org. Let's leave it alone.

I suggest we land the image @zcorpan created as tracking.svg and also rename the classes as appropriate and standardize around that. I'm happy to take on that work.

@annevk
Copy link
Member

annevk commented Sep 23, 2019

I've done the rename (to tracking-vector.svg) and consider this okay now. New logos under a compatible license are welcome and will remain welcome once this lands.

@zcorpan zcorpan mentioned this pull request Sep 23, 2019
Merged
annevk added a commit to whatwg/html that referenced this pull request Sep 24, 2019
@annevk
Use Infra as infrastructure for tracking/fingerprinting marking
e7a8ffb 
This depends on whatwg/wattsi#41, whatwg/infra#115 (which depends on speced/bikeshed#964), and whatwg/whatwg.org#64.
@annevk annevk mentioned this pull request Sep 24, 2019
Merged
@tabatkins tabatkins mentioned this pull request Sep 25, 2019
Closed
@annevk annevk mentioned this pull request Sep 25, 2019
Closed
@zcorpan
Copy link
Member Author

zcorpan commented Sep 25, 2019

LGTM

@vikramcs vikramcs mentioned this pull request Oct 23, 2019
Open
3 tasks
@snuggs
Copy link
Member

snuggs commented Nov 22, 2019

LGTM. Far less semantic/understandable until @annevk changed the name. /cc @sideshowbarker

@annevk annevk mentioned this pull request Jan 6, 2020
Merged
@annevk annevk changed the title Add a fingerprint image Add a tracking vector image Jan 7, 2020
@annevk annevk mentioned this pull request Jan 7, 2020
Merged
@annevk
Copy link
Member

annevk commented Jan 7, 2020

I'm going to merge this as it doesn't affect the HTML Standard as I thought it would. That currently has inline CSS for fingerprint.

@annevk annevk merged commit 08c7d5f into master Jan 7, 2020
@annevk annevk deleted the zcorpan/fingerprint branch January 7, 2020 09:45
annevk added a commit to whatwg/html that referenced this pull request Jan 7, 2020
@annevk
Use Infra as infrastructure for tracking/fingerprinting marking
db25ece 
This depends on whatwg/wattsi#41, whatwg/infra#115 (which depends on speced/bikeshed#964), and whatwg/whatwg.org#64.
annevk added a commit to whatwg/html that referenced this pull request Jan 15, 2020
@annevk
Use Infra as infrastructure for tracking/fingerprinting marking
febea88 
This depends on whatwg/wattsi#41, whatwg/infra#115 (which depends on speced/bikeshed#964), and whatwg/whatwg.org#64.
annevk added a commit to whatwg/wattsi that referenced this pull request Jan 16, 2020
@zcorpan @annevk
Fringerprint -> tracking vector
a931147 
See whatwg/whatwg.org#64 and whatwg/html#4933.

Co-authored-by: Anne van Kesteren <[email protected]>
annevk added a commit to whatwg/html that referenced this pull request Jan 16, 2020
@annevk
Use Infra for tracking vector/fingerprint marking
eefd525 
This builds on whatwg/wattsi#41, whatwg/infra#115 (which builds on speced/bikeshed#964), and whatwg/whatwg.org#64.
annevk added a commit to whatwg/html that referenced this pull request Jan 16, 2020
@annevk
Use Infra for tracking vector/fingerprint marking
c78118d 
This builds on whatwg/wattsi#41, whatwg/infra#115 (which builds on speced/bikeshed#964), and whatwg/whatwg.org#64.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create fingerprint.svg
4 participants
@zcorpan @annevk @foolip @snuggs