Move twitter.com hrefs over to x.com #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change twitter.com hrefs over to x.com
domenic
approved these changes
May 21, 2024
|
Although, we should probably update various other instances, e.g. https://whatwg.org/ itself. |
|
I made that change, I couldn't any other instances on whatwg/whatwg.org or whatwg/sg. Although should we switch whatwg.org/whatwg.org/img/bird-webpage.svg to an "X" SVG? |
|
Yes, that would be nice. Thanks for doing that. We should also delete the old one. Let me give it a shot... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 2024-05-17, X (formerly Twitter) has migrated their hosting domain over to x.com and twitter.com now pulls a HTTP 302 redirect whereas x.com is 200.
Renaming the "twitter" values in db.json and db.py in the sg repo, and in convert_sg_db.py (and elsewhere) is up for discussion if it's truly needed.