Disallow constants to be null#686
Merged
Merged
Conversation
annevk
approved these changes
Mar 11, 2019
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
I'm surprised we allow them to be booleans.
Member
|
Travis is complaining about the grammar, it seems. |
Member
|
Can someone explain "restore ConstType to not break WebGL"? It seems better not to have it. |
Member
|
WebGL uses typedefs for integer types, so we kinda need to support that. |
Member
|
How is that related to the ConstType grammar production? |
Member
Author
|
WebGL has a lot of |
Collaborator
|
Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1535647 on Gecko. |
saschanaz
added a commit
to saschanaz/weedle3
that referenced
this pull request
Jan 15, 2023
Corresponds to whatwg/webidl#686
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #448.
No known specs are using constant null, and we discourage adding new constants (with some specs as exceptions), so I think we can safely remove this.
Preview | Diff