Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify PropertyDescriptor of @@toStringTag symbol #513

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Specify PropertyDescriptor of @@toStringTag symbol #513

merged 1 commit into from
Jan 19, 2018

Conversation

tobie
Copy link
Collaborator

@tobie tobie commented Jan 19, 2018 •
edited by pr-preview bot
Loading

@domenic
Copy link
Member

domenic commented Jan 19, 2018

LGTM, although somewhat non-actionable for implementations/tests until #357 is straightened out.

@tobie
Copy link
Collaborator Author

tobie commented Jan 19, 2018

Oh, absolutely. I initially included @@toStringTag in the imperative branch but backed out because of #357. Still felt like clearing this issue out was worth it.

@tobie tobie merged commit 41bc728 into whatwg:master Jan 19, 2018
@tobie tobie deleted the tostringtag branch January 19, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobie @domenic