-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow same identifier in static and regular ops #1098
Allow same identifier in static and regular ops #1098
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[spam]
@TimothyGu / @EdgarChen would you mind taking a look? This is a prerequisite for whatwg/fetch#1392. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
I checked how we handle the overloaded operations, there are separated overload set for regular and static operation, so I think it is fine to have same identifier in regular and static operations.
@TimothyGu, WDYT? |
BTW, I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1765992 for Gecko. |
Thanks @EdgarChen. Added the link to the PR description. I'll open a WebKit issue in a moment. Can I count Gecko and Chromium as interested implementers for the working mode requirements? |
+1 to this. Definitely useful |
cc @tabatkins, as this may affect bikeshed IDL handling too. |
Yeah, thanks for the ping. I will indeed need to make a change in how Bikeshed handles these. (The change makes sense tho, so Bikeshed shouldn't be a blocker here.) |
This commit adds support for having regular and static ops with the same name on a WebIDL interface. The corresponding spec change is whatwg/webidl#1098. Bug: 1305399 Change-Id: Id414ac980772252a40715c0d928021b6df5989a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3623640 Auto-Submit: Luca Casonato <[email protected]> Reviewed-by: Yuki Shiino <[email protected]> Commit-Queue: Yuki Shiino <[email protected]> Reviewed-by: Kentaro Hara <[email protected]> Cr-Commit-Position: refs/heads/main@{#1001427}
Support for this was merged in Chromium (https://chromium-review.googlesource.com/c/chromium/src/+/3623640), so we have two "interested implementers" now. @EdgarChen think we can land this? |
I think this will impact MDN documentation, because static and instance members aren’t distinguished in the URL convention. Does anyone have a plan for that? |
From what I understand MDN has had some consensus to move away from their current pretend-all-methods-are-static style for some time, but I haven't seen any actual updates: https://github.com/mdn/content/discussions/5121 and some other discussions. |
It's been discussed, but there weren't any plans for anyone to work on it. I've commented on https://github.com/mdn/content/discussions/5121 and filed openwebdocs/project#104 to put it on the radar, but I would expect |
This commit adds support for having regular and static ops with the same name on a WebIDL interface. The corresponding spec change is whatwg/webidl#1098. Bug: 1305399 Change-Id: Id414ac980772252a40715c0d928021b6df5989a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3623640 Auto-Submit: Luca Casonato <[email protected]> Reviewed-by: Yuki Shiino <[email protected]> Commit-Queue: Yuki Shiino <[email protected]> Reviewed-by: Kentaro Hara <[email protected]> Cr-Commit-Position: refs/heads/main@{#1001427} NOKEYCHECK=True GitOrigin-RevId: 7aabcead1773e2cc6775dff9f570afec6c3af2c6
Closes #1097
N/A
Preview | Diff