Use Rope.Append to set sha-link attribute

This reverts 0751161 in favor of using Rope.Append in roughly the same sort of way it’s used in similar cases in the source.
whatwg · May 19, 2018 · 6d066f9 · 6d066f9
1 parent d77afcf
commit 6d066f9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/lib/settings.inc b/src/lib/settings.inc
@@ -1,4 +1,5 @@
 {$MACRO ON}
+{$WRITEABLECONST OFF}
 {$VARPROPSETTER OFF}
 {$LONGSTRINGS ON}
 {$OPENSTRINGS OFF}

diff --git a/src/wattsi.pas b/src/wattsi.pas
@@ -602,7 +602,7 @@    TCrossReferences = record
 
    function ProcessNode(var Node: TNode): Boolean; // return True if we are to keep this node, False if we drop it
    const
-      SourceGitSHALink: AnsiString = '';
+      SourceGitBaseURL: AnsiString = 'https://github.com/whatwg/html/commit/';
    var
       CandidateChild, SelectedForTransfer: TNode;
       CurrentHeadingRank: THeadingRank;
@@ -951,8 +951,10 @@    TCrossReferences = record
          begin
             Element.AppendChild(TText.Create(SourceGitSHA));
             Element.AppendChild(TText.Create(' commit'));
-            SourceGitSHALink := 'https://github.com/whatwg/html/commit/' + SourceGitSHA;
-            Element.SetAttribute('href', SourceGitSHALink);
+            Scratch := Default(Rope);
+            Scratch.Append(@SourceGitBaseURL);
+            Scratch.Append(@SourceGitSHA);
+            Element.SetAttributeDestructively('href', Scratch);
          end
          else
          if (Element.isIdentity(nsHTML, eA) and (not Element.HasAttribute(kHrefAttribute))) then