Editorial: attempt to deduplicate the file state #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
commented
May 11, 2020
| <ol> | ||
| <li><p><a>Validation error</a>. | ||
|
|
||
| <li><p>Set <var>url</var>'s <a for=url>host</a> to null and <var>url</var>'s |
There was a problem hiding this comment.
As host is cleared in https://url.spec.whatwg.org/#path-state (though to "", not null) perhaps it's better to keep it here, also in light of #302.
domenic
approved these changes
May 14, 2020
domenic
pushed a commit
to jsdom/whatwg-url
that referenced
this pull request
May 14, 2020
Follows whatwg/url#512.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe helps with #504, though this is much less convincing than #509 I think.
I also noticed there is not good coverage for file base URLs.
Preview | Diff