Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ReadableStreamBYOBReader.prototype.read(view, { min }) #1145

Merged
merged 43 commits into from
Nov 13, 2023
Merged

Add ReadableStreamBYOBReader.prototype.read(view, { min }) #1145

merged 43 commits into from
Nov 13, 2023

Commits on Jun 9, 2023

  1. Add ReadableStreamBYOBReader.readFully() (first attempt)

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    db1985e View commit details
    Browse the repository at this point in the history

  2. Revert "Add ReadableStreamBYOBReader.readFully() (first attempt)" 

    This reverts commit ccdf1d1.
    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    13d5794 View commit details
    Browse the repository at this point in the history

  3. Add ReadableStreamBYOBReader.readFully()

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    cce92e2 View commit details
    Browse the repository at this point in the history

  4. Use dual asserts

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    0326e95 View commit details
    Browse the repository at this point in the history

  5. Remove unused default value

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    864e010 View commit details
    Browse the repository at this point in the history

  6. Explain why we keep the readFully() pull-into descriptor at the head … 

    …of the queue
    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    09a199b View commit details
    Browse the repository at this point in the history

  7. Roll WPT

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    5730f08 View commit details
    Browse the repository at this point in the history

  8. Fix typos

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    8ab2bbc View commit details
    Browse the repository at this point in the history

  9. Add spec text for readFully()

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    78d2711 View commit details
    Browse the repository at this point in the history

  10. Tweak note

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    101fa7f View commit details
    Browse the repository at this point in the history

  11. Add note about readFully() in readInto() example

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    405cfb1 View commit details
    Browse the repository at this point in the history

  12. Always copy all queued bytes if readFully descriptor is not yet full

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    345eb40 View commit details
    Browse the repository at this point in the history

  13. Roll WPT

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    3201762 View commit details
    Browse the repository at this point in the history

  14. Simplify

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    b7c89fb View commit details
    Browse the repository at this point in the history

  15. Roll WPT

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    9725a70 View commit details
    Browse the repository at this point in the history

  16. Replace "theChunk" and "theView" with "newView"

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    d3bc471 View commit details
    Browse the repository at this point in the history

  17. Fix extra space

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    0d968aa View commit details
    Browse the repository at this point in the history

  18. Explain newView.byteLength

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    e9efa23 View commit details
    Browse the repository at this point in the history

  19. Rename readFully() to fill()

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    c8a4dfc View commit details
    Browse the repository at this point in the history

  20. Roll WPT

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    51dc85b View commit details
    Browse the repository at this point in the history

  21. Generalize fill(view)

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    e6b1218 View commit details
    Browse the repository at this point in the history

  22. Rename

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    5d967c9 View commit details
    Browse the repository at this point in the history

  23. Update spec text

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    511b3ae View commit details
    Browse the repository at this point in the history

  24. Add atLeast option to byobReader.read()

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    66dd27b View commit details
    Browse the repository at this point in the history

  25. Remove fill(view)

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    3f1f12f View commit details
    Browse the repository at this point in the history

  26. Roll WPT

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    d7ae44e View commit details
    Browse the repository at this point in the history

  27. Fix note

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    1e1d6c6 View commit details
    Browse the repository at this point in the history

  28. Reject with a TypeError if atLeast is 0

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    15409a3 View commit details
    Browse the repository at this point in the history

  29. Roll WPT

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    2b11471 View commit details
    Browse the repository at this point in the history

  30. Rename "atLeast" to "min"

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    1f3d73f View commit details
    Browse the repository at this point in the history

  31. Roll WPT

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    3bc1283 View commit details
    Browse the repository at this point in the history

  32. Roll WPT

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    f1572e5 View commit details
    Browse the repository at this point in the history

  33. Fix typo

    @MattiasBuelens
    MattiasBuelens committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    78f7adc View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2023

  1. Set ReadableStreamBYOBReaderReadOptions.min = 1 by default

    @MattiasBuelens
    MattiasBuelens committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    6f5196a View commit details
    Browse the repository at this point in the history

  2. Roll WPT

    @MattiasBuelens
    MattiasBuelens committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    8f2e4a4 View commit details
    Browse the repository at this point in the history

  3. Rename minimumFill to min in ReadableStreamBYOBReaderRead, and make r… 

    …equired
    @MattiasBuelens
    MattiasBuelens committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    d17aeca View commit details
    Browse the repository at this point in the history

  4. Move readIntoRequest to last argument

    @MattiasBuelens
    MattiasBuelens committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    e381f25 View commit details
    Browse the repository at this point in the history

  5. Fix lint error

    @MattiasBuelens
    MattiasBuelens committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    c39be05 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Small improvements

    @domenic
    domenic committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    9351f13 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2023

  1. Merge branch 'main' into rs-byob-read-fully

    @MattiasBuelens
    MattiasBuelens committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    c09f1c7 View commit details
    Browse the repository at this point in the history

  2. Roll WPT

    @MattiasBuelens
    MattiasBuelens committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    99b7f42 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Replace "x mod y" with "the remainder after dividing x by y"

    @MattiasBuelens
    MattiasBuelens committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    547805f View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Roll WPT

    @MattiasBuelens
    MattiasBuelens committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    b938532 View commit details
    Browse the repository at this point in the history