Specify a limit in HTMLOptionsCollection.length setter. #8347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
requested changes
Oct 3, 2022
There was a problem hiding this comment.
This just updates the "For web developers (non-normative)" text; you need to update the normative algorithm which says
On setting, the behavior depends on whether the new value is equal to, greater than, or less than
Feel free to rewrite that as a real algorithm with steps and stuff, if that'd make things easier...
emilio
force-pushed
the
HTMLOptionsCollection-length-setter
branch
from
43746da to
001c6c0
Compare
I think it's done, please take a look. Thanks! |
Thanks. My only request would be change 10,000 –> 100,000. |
This aligns with WebKit's behavior, but bumps the limit with 100k, as per the discussion in whatwg#8337. Co-authored-by: Domenic Denicola <[email protected]>
emilio
force-pushed
the
HTMLOptionsCollection-length-setter
branch
from
2c70ce4 to
703a99f
Compare
|
Okay, I updated the limit to 100k, as per discussion here and in the issue. |
|
I'll merge this now! I did notice that, by putting the return-if-over-100K line inside the "If the given value is greater than current" line, means that if I have a |
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 28, 2022
As per the discussion in whatwg/html#8347 Differential Revision: https://phabricator.services.mozilla.com/D160544 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1797792 gecko-commit: bdd3a81d328efa4627647bcc54e8b09878014c92 gecko-reviewers: smaug
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 28, 2022
As per the discussion in whatwg/html#8347 Differential Revision: https://phabricator.services.mozilla.com/D160544
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 28, 2022
As per the discussion in whatwg/html#8347 Differential Revision: https://phabricator.services.mozilla.com/D160544 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1797792 gecko-commit: bdd3a81d328efa4627647bcc54e8b09878014c92 gecko-reviewers: smaug
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Oct 31, 2022
As per the discussion in whatwg/html#8347 Differential Revision: https://phabricator.services.mozilla.com/D160544
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 10, 2022
Update the const kMaxListItems to be 100,000 in HTMLOptionsCollections to reflect updated spec. Also, this max should only be used when new length is greater than current length. [1] https://html.spec.whatwg.org/#dom-htmloptionscollection-length [2] whatwg/html#8337 [3] whatwg/html#8347 Change-Id: I7ff54e9cfdcb2eb014ad508485eda6908308314b Fixed: 1370370
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 11, 2022
Update the const kMaxListItems to be 100,000 in HTMLOptionsCollections to reflect updated spec. Also, this max should only be used when new length is greater than current length. [1] https://html.spec.whatwg.org/#dom-htmloptionscollection-length [2] whatwg/html#8337 [3] whatwg/html#8347 Change-Id: I7ff54e9cfdcb2eb014ad508485eda6908308314b Fixed: 1370370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4015681 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Di Zhang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1070388}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 11, 2022
Update the const kMaxListItems to be 100,000 in HTMLOptionsCollections to reflect updated spec. Also, this max should only be used when new length is greater than current length. [1] https://html.spec.whatwg.org/#dom-htmloptionscollection-length [2] whatwg/html#8337 [3] whatwg/html#8347 Change-Id: I7ff54e9cfdcb2eb014ad508485eda6908308314b Fixed: 1370370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4015681 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Di Zhang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1070388}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 21, 2022
…ection.length setter, a=testonly Automatic update from web-platform-tests Restore 100,000 limit in HTMLOptionsCollection.length setter Update the const kMaxListItems to be 100,000 in HTMLOptionsCollections to reflect updated spec. Also, this max should only be used when new length is greater than current length. [1] https://html.spec.whatwg.org/#dom-htmloptionscollection-length [2] whatwg/html#8337 [3] whatwg/html#8347 Change-Id: I7ff54e9cfdcb2eb014ad508485eda6908308314b Fixed: 1370370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4015681 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Di Zhang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1070388} -- wpt-commits: 893a5f3fa49a459b94526de606e89856dcbb5dae wpt-pr: 36917
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Nov 21, 2022
…ection.length setter, a=testonly Automatic update from web-platform-tests Restore 100,000 limit in HTMLOptionsCollection.length setter Update the const kMaxListItems to be 100,000 in HTMLOptionsCollections to reflect updated spec. Also, this max should only be used when new length is greater than current length. [1] https://html.spec.whatwg.org/#dom-htmloptionscollection-length [2] whatwg/html#8337 [3] whatwg/html#8347 Change-Id: I7ff54e9cfdcb2eb014ad508485eda6908308314b Fixed: 1370370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4015681 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Di Zhang <[email protected]> Cr-Commit-Position: refs/heads/main@{#1070388} -- wpt-commits: 893a5f3fa49a459b94526de606e89856dcbb5dae wpt-pr: 36917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns with WebKit's behavior as per the discussion in #8337.
/common-dom-interfaces.html ( diff )