Use "queue an element task" properly in script preparation #8072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the task had no specified task source.
|
lol I forgot I had targeted the import maps spec here... @annevk can you approve, based on the first commit? I think I have a couple merge conflicts to fix too, but I'll work on that... |
domenic
force-pushed
the
task-source-for-script
branch
from
1e55204
to
669c64c
Compare
domenic
force-pushed
the
task-source-for-script
branch
from
669c64c
to
84108ac
Compare
This imports much of the specification from https://wicg.github.io/import-maps/. The main deltas are: * Does not include support for external import maps. This allows a good deal of simplification, such as by changing "acquiring import maps" + "pending import map script" + "wait for import maps" to a single "import maps allowed" boolean, or integrating "register an import map" into "execute the script element". If a src="" attribute is present on an importmap script element, then an error event is fired. See #8355. * Does not include any support for non-Window import maps. The spec draft included stub support for those, with other globals always having an empty import map. This instead ties import maps to Windows directly. If we revisit that in the future we can refactor, but keeping always-empty import maps around on the other globals was clumsy. * Adds introductory text and examples. * Adds conformance requirements, both on the script element and on the import map JSON. * Fixes a few minor specification issues: WICG/import-maps#267, WICG/import-maps#268, WICG/import-maps#270, WICG/import-maps#276, WICG/import-maps#277.
domenic
force-pushed
the
task-source-for-script
branch
from
84108ac
to
dacf8df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the task had no specified task source.
Because task sources are not very observable, this is mostly good spec hygiene.
(See WHATWG Working Mode: Changes for more details.)
/acknowledgements.html ( diff )
/index.html ( diff )
/infrastructure.html ( diff )
/references.html ( diff )
/scripting.html ( diff )
/webappapis.html ( diff )