-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Html script element supports method #7008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good to me, modulo some minor nits.
Let's also add a domintro section, even though only script.text has one so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
225c56e
to
1cfe8f2
Compare
The script.supports() method will be introduced by whatwg/html#7008. script.supports('importmap') must return true when supported. Fixes WICG#171
The script.supports() method will be introduced by whatwg/html#7008. script.supports('speculationrules') must return true when supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you! I'll let @domenic do a final check.
Also looks good to me. +1 > @domenic for final check. |
source
Outdated
@@ -58589,6 +58591,30 @@ interface <dfn interface>HTMLScriptElement</dfn> : <span>HTMLElement</span> { | |||
<code data-x="dom-innerHTML">innerHTML</code> and <code data-x="dom-outerHTML">outerHTML</code> | |||
attributes, they do not execute at all.</p> | |||
|
|||
|
|||
<dl class="domintro"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally keep the domintro contents together. So I think you can merge this with the previous one for script.text
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait. I think this should be a static method, not an instance method. That is what #6472 proposed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait. I think this should be a static method, not an instance method. That is what #6472 proposed.
Ah, yes. Updated this PR to use static.
source
Outdated
@@ -58589,6 +58591,30 @@ interface <dfn interface>HTMLScriptElement</dfn> : <span>HTMLElement</span> { | |||
<code data-x="dom-innerHTML">innerHTML</code> and <code data-x="dom-outerHTML">outerHTML</code> | |||
attributes, they do not execute at all.</p> | |||
|
|||
|
|||
<dl class="domintro"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging!
@horo-t please remember to file Mozilla and WebKit bugs, and update the original post to link to them. |
Filed bugs and updated the original post. |
The HTMLScriptElement.supports() method was introduced by whatwg/html#7008. HTMLScriptElement.supports('importmap') must return true when supported. Fixes WICG#171
The HTMLScriptElement.supports() method was introduced by whatwg/html#7008. HTMLScriptElement.supports('speculationrules') must return true when supported.
The HTMLScriptElement.supports() method was introduced by whatwg/html#7008. HTMLScriptElement.supports('importmap') must return true when supported. Fixes WICG#171
The HTMLScriptElement.supports() method was introduced by whatwg/html#7008. This makes HTMLScriptElement.supports('importmap') return true. Fixes #171.
This PR reflects the feedback from the TAG review: w3ctag/design-reviews#674 The original HTMLScriptElement.supports() was introduced by whatwg#7008.
The HTMLScriptElement.supports() method was introduced by whatwg/html#7008. HTMLScriptElement.supports('speculationrules') must return true when supported.
The HTMLScriptElement.supports() method was introduced by whatwg/html#7008. HTMLScriptElement.supports('speculationrules') must return true when supported.
(See WHATWG Working Mode: Changes for more details.)
/acknowledgements.html ( diff )
/infrastructure.html ( diff )
/scripting.html ( diff )