Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow serializing and transferring non-origin-clean ImageBitmap #5114

Conversation

yutakahirano
Copy link
Member

@yutakahirano yutakahirano commented Nov 29, 2019

This feature brings extra complexity for Cross-Origin-Opener-Policy and
Cross-Origin-Embedder-Policy. As this feature is rarely used I'm proposing
removing it.

Relevant discussion:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Z1XdYf6SjDU

(See WHATWG Working Mode: Changes for more details.)


/imagebitmap-and-animations.html ( diff )

source Show resolved Hide resolved
This feature brings extra complexity for Cross-Origin-Opener-Policy and
Cross-Origin-Embedder-Policy. As this feature is rarely used I'm proposing
removing it.

Relevant discussion:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Z1XdYf6SjDU
@yutakahirano yutakahirano force-pushed the yhirano/non-origin-clean-imagebitmap-serialization-transferring branch from f829336 to 71f2ea7 Compare November 29, 2019 06:46
@annevk annevk added the do not merge yet Pull request must not be merged per rationale in comment label Nov 29, 2019
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving a formal LGTM although we indeed won't merge this until you tell us it's safe to do so :)

@yutakahirano
Copy link
Member Author

I think this is now ready to land.

@domenic domenic removed the do not merge yet Pull request must not be merged per rationale in comment label Dec 18, 2019
@domenic domenic merged commit ef4d727 into whatwg:master Dec 18, 2019
yutakahirano added a commit to web-platform-tests/wpt that referenced this pull request Dec 19, 2019
…20526)

The tests update for whatwg/html#5114.
Add one test case for serialization, add one test case for
transferring. The relationship between COOP/COEP is now clear
and we can remove no-coop-coep.https.window.js.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 23, 2019
…n-origin-clean ImageBitmap, a=testonly

Automatic update from web-platform-tests
Disallow serializing and transferring non-origin-clean ImageBitmap (#20526)

The tests update for whatwg/html#5114.
Add one test case for serialization, add one test case for
transferring. The relationship between COOP/COEP is now clear
and we can remove no-coop-coep.https.window.js.
--

wpt-commits: 578b1c621b57c2ad51442cb273bd5b8ea1dfed63
wpt-pr: 20526
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Dec 23, 2019
…n-origin-clean ImageBitmap, a=testonly

Automatic update from web-platform-tests
Disallow serializing and transferring non-origin-clean ImageBitmap (#20526)

The tests update for whatwg/html#5114.
Add one test case for serialization, add one test case for
transferring. The relationship between COOP/COEP is now clear
and we can remove no-coop-coep.https.window.js.
--

wpt-commits: 578b1c621b57c2ad51442cb273bd5b8ea1dfed63
wpt-pr: 20526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants