-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow serializing and transferring non-origin-clean ImageBitmap #5114
Merged
domenic
merged 1 commit into
whatwg:master
from
yutakahirano:yhirano/non-origin-clean-imagebitmap-serialization-transferring
Dec 18, 2019
Merged
Disallow serializing and transferring non-origin-clean ImageBitmap #5114
domenic
merged 1 commit into
whatwg:master
from
yutakahirano:yhirano/non-origin-clean-imagebitmap-serialization-transferring
Dec 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
Nov 29, 2019
This feature brings extra complexity for Cross-Origin-Opener-Policy and Cross-Origin-Embedder-Policy. As this feature is rarely used I'm proposing removing it. Relevant discussion: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Z1XdYf6SjDU
yutakahirano
force-pushed
the
yhirano/non-origin-clean-imagebitmap-serialization-transferring
branch
from
November 29, 2019 06:46
f829336
to
71f2ea7
Compare
annevk
added
the
do not merge yet
Pull request must not be merged per rationale in comment
label
Nov 29, 2019
domenic
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving a formal LGTM although we indeed won't merge this until you tell us it's safe to do so :)
I think this is now ready to land. |
domenic
removed
the
do not merge yet
Pull request must not be merged per rationale in comment
label
Dec 18, 2019
yutakahirano
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 19, 2019
…20526) The tests update for whatwg/html#5114. Add one test case for serialization, add one test case for transferring. The relationship between COOP/COEP is now clear and we can remove no-coop-coep.https.window.js.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 23, 2019
…n-origin-clean ImageBitmap, a=testonly Automatic update from web-platform-tests Disallow serializing and transferring non-origin-clean ImageBitmap (#20526) The tests update for whatwg/html#5114. Add one test case for serialization, add one test case for transferring. The relationship between COOP/COEP is now clear and we can remove no-coop-coep.https.window.js. -- wpt-commits: 578b1c621b57c2ad51442cb273bd5b8ea1dfed63 wpt-pr: 20526
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Dec 23, 2019
…n-origin-clean ImageBitmap, a=testonly Automatic update from web-platform-tests Disallow serializing and transferring non-origin-clean ImageBitmap (#20526) The tests update for whatwg/html#5114. Add one test case for serialization, add one test case for transferring. The relationship between COOP/COEP is now clear and we can remove no-coop-coep.https.window.js. -- wpt-commits: 578b1c621b57c2ad51442cb273bd5b8ea1dfed63 wpt-pr: 20526
3 tasks
Closed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature brings extra complexity for Cross-Origin-Opener-Policy and
Cross-Origin-Embedder-Policy. As this feature is rarely used I'm proposing
removing it.
Relevant discussion:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Z1XdYf6SjDU
(See WHATWG Working Mode: Changes for more details.)
/imagebitmap-and-animations.html ( diff )