Define getSVGDocument() in terms of content document #5109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, make content document (also used by contentDocument) perform the same origin-domain comparison on the two documents involved. Tests: web-platform-tests/wpt#20432. Fixes #5094.
domenic
reviewed
Dec 3, 2019
| object</span> are not <span>same origin-domain</span>, then return null.</p></li> | ||
| <li><p>If <var>document</var>'s <span>origin</span> and <var>container</var>'s <span>node | ||
| document</span>'s <span>origin</span> are not <span>same origin-domain</span>, then return | ||
| null.</p></li> |
There was a problem hiding this comment.
What is the motivation for this change from checking the current settings object to checking container's node document? Did you mean to check both? Or is there a reason why checking both would be redundant?
There was a problem hiding this comment.
It aligns it with getSVGDocument() which is how implementations do it, as far as I can tell.
domenic
approved these changes
Dec 9, 2019
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 13, 2019
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 19, 2019
…, a=testonly Automatic update from web-platform-tests HTML: getSVGDocument() / contentDocument For whatwg/html#5094 and whatwg/html#5109. -- wpt-commits: b5f3eafc45e9e2aa2d502af321d0e8aa704ac5f9 wpt-pr: 20432
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 20, 2019
…, a=testonly Automatic update from web-platform-tests HTML: getSVGDocument() / contentDocument For whatwg/html#5094 and whatwg/html#5109. -- wpt-commits: b5f3eafc45e9e2aa2d502af321d0e8aa704ac5f9 wpt-pr: 20432 UltraBlame original commit: 9d599fcfcf1f233f299313f4c2b28e2ce31aca43
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 20, 2019
…, a=testonly Automatic update from web-platform-tests HTML: getSVGDocument() / contentDocument For whatwg/html#5094 and whatwg/html#5109. -- wpt-commits: b5f3eafc45e9e2aa2d502af321d0e8aa704ac5f9 wpt-pr: 20432 UltraBlame original commit: 9d599fcfcf1f233f299313f4c2b28e2ce31aca43
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 20, 2019
…, a=testonly Automatic update from web-platform-tests HTML: getSVGDocument() / contentDocument For whatwg/html#5094 and whatwg/html#5109. -- wpt-commits: b5f3eafc45e9e2aa2d502af321d0e8aa704ac5f9 wpt-pr: 20432 UltraBlame original commit: 9d599fcfcf1f233f299313f4c2b28e2ce31aca43
lissyx
pushed a commit
to lissyx/mozilla-central
that referenced
this pull request
Dec 20, 2019
…, a=testonly Automatic update from web-platform-tests HTML: getSVGDocument() / contentDocument For whatwg/html#5094 and whatwg/html#5109. -- wpt-commits: b5f3eafc45e9e2aa2d502af321d0e8aa704ac5f9 wpt-pr: 20432
This was referenced Apr 13, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, make content document (also used by contentDocument) perform the same origin-domain comparison on the two documents involved.
Tests: web-platform-tests/wpt#20432.
Fixes #5094.
/browsers.html ( diff )
/embedded-content-other.html ( diff )