Add Accessibility considerations concept #5077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- definition - for anchor element - for input element types - for button element
|
Draft URLs are preferred, looks okay to me overall. |
domenic
reviewed
Nov 13, 2019
- remove "on HTML elements" from definition (not needed) - lowercase "accessibility" in definition - for anchor, use "If the element has an href attribute:" for consistency with Categories prose - format lines for 100 char maximum
…side, audio, b, base, bdi, bdo
…aption, cite, code, col, colgroup
…s, dfn, dialog, div, dl, dt
…, figure, footer, form, h1-h6, head
…bdi, bdo, br, cite, code, data, dfn (see w3c/html-aria#202)
…ain, map, mark, menu
…ect, ol, optgroup, option, output, p
…q, rp, rt, ruby, s, samp
… slot, source, span
…mary, table, tbody, td, template
…e, title, tr, track, u, ul
|
@domenic @annevk
These links will be good when the following PRs are merged; but merging is currently waiting on an unrelated respec problem:
So I'm marking this as ready for review now because I don't want to hold up this PR. As soon as the 3 links go in, I'll create a new PR to add the above 3 lines back in. |
domenic
approved these changes
Dec 13, 2019
There was a problem hiding this comment.
This looks amazing; thank you so much @carmacleod. I'll hold off merging so you can add those three lines back in? But after you do I'm happy to merge.
…ks exist." This reverts commit 7a469fd
|
The 3 lines are back in, and all links are valid. Ok to merge! Thanks for all the help! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@domenic @annevk
Please note that I have created this as a Draft PR.
Questions & notes:
data-x-hrefbut nothing is being defined here, so that's not a good fit./acknowledgements.html ( diff )
/canvas.html ( diff )
/dom.html ( diff )
/edits.html ( diff )
/embedded-content.html ( diff )
/form-elements.html ( diff )
/forms.html ( diff )
/grouping-content.html ( diff )
/iframe-embed-object.html ( diff )
/image-maps.html ( diff )
/input.html ( diff )
/interactive-elements.html ( diff )
/media.html ( diff )
/scripting.html ( diff )
/sections.html ( diff )
/semantics.html ( diff )
/tables.html ( diff )
/text-level-semantics.html ( diff )