Define (schemelessly) same site for origins #5076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helpers with whatwg/url#448.
mikewest
approved these changes
Nov 12, 2019
annevk
reviewed
Nov 12, 2019
|
Nits fixed. @annevk any reason to hold off on merging this? I guess maybe we should get all the call site updates lined up beforehand? Or just go for it... |
annevk
approved these changes
Nov 19, 2019
|
I'm okay with going for it. I don't really have a list of all callers unfortunately, except for the one in Fetch. |
domenic
added a commit
to whatwg/fetch
that referenced
this pull request
Nov 20, 2019
Follows whatwg/html#5076. See #969 for a potential normative follow-up to change this to use "same site".
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpers with whatwg/url#448.
/cc @mikewest
I think establishing this for now makes the most sense. We can later work on introducing potential "site" or "schemeless site" concepts directly, but for now, we should get a proper definition of these equality relations, as applied to origins.
/infrastructure.html ( diff )
/origin.html ( diff )