Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autofocus: Change the timing of 'flush autofocus candidates' #5015

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

tkent-google
Copy link
Contributor

@tkent-google tkent-google commented Oct 17, 2019

so that it is run before 'run the resize steps'.

The previous timing could cause an issue that the auto-focused element
didn't have up-to-date appearance even though 'update the rendering' was
done.

This fixes #4992

(See WHATWG Working Mode: Changes for more details.)


/webappapis.html ( diff )

so that it is run before 'run the resize steps'.

The previous timing could cause an issue that the auto-focused element
didn't have up-to-date appearance even though 'update the rendering' was
done.

This fixes whatwg#4992
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is this testable?

@rniwa
Copy link

rniwa commented Oct 17, 2019

LGTM. Is this testable?

Definitely.

@domenic domenic added the needs tests Moving the issue forward requires someone to write tests label Oct 17, 2019
@tkent-google
Copy link
Contributor Author

LGTM. Is this testable?

Definitely.

web-platform-tests/wpt#19747

@domenic domenic removed the needs tests Moving the issue forward requires someone to write tests label Oct 18, 2019
@domenic domenic merged commit 74b6124 into whatwg:master Oct 18, 2019
@tkent-google tkent-google deleted the tkent-move-flush-autofocus branch October 28, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Flushing of autofocus candidates should happen before updating the rendering of documents
3 participants