Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert JSON modules #4943

Merged
merged 4 commits into from
Oct 2, 2019
Merged

Revert JSON modules #4943

merged 4 commits into from
Oct 2, 2019

Conversation

annevk
Copy link
Member

@annevk annevk commented Sep 28, 2019

As explained at WICG/webcomponents#839 the current setup is insecure.

This reverts db03474.

TODO:

cc @littledan @Ms2ger


/infrastructure.html ( diff )
/scripting.html ( diff )
/timers-and-user-prompts.html ( diff )
/webappapis.html ( diff )

As explained at WICG/webcomponents#839 the current setup is insecure.

This reverts db03474.
@annevk annevk added the removal/deprecation Removing or deprecating a feature label Sep 28, 2019
@annevk
Copy link
Member Author

annevk commented Sep 28, 2019

Perhaps we should take a different approach though as Wasm modules could use much of the infrastructure created here.

@littledan
Copy link
Contributor

It seems clear that JSON modules have lost multi-engine support, so removing from the spec sounds good. I suppose we should also remove the wpt tests. Let's not worry about Wasm modules for now--it will be easy to add this infrastructure back when it's time.

@rniwa
Copy link

rniwa commented Sep 30, 2019

Given the security issue we raised, we support removing this from the spec at least for now.

@annevk
Copy link
Member Author

annevk commented Oct 1, 2019

@littledan could you have another look as it seems I missed some things initially. Unfortunately git backout X didn't create a clean patch.

annevk added a commit to web-platform-tests/wpt that referenced this pull request Oct 1, 2019
@annevk
Copy link
Member Author

annevk commented Oct 1, 2019

I've notified the original implementation bugs:

(I also created a PR to mark all WPT tests as tentative.)

Ms2ger pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 1, 2019
@littledan
Copy link
Contributor

I don't quite have the energy to follow up here during TC39. Maybe @Ms2ger could help sooner.

source Show resolved Hide resolved
@annevk annevk merged commit a530f6f into master Oct 2, 2019
@annevk annevk deleted the annevk/revert-json-modules branch October 2, 2019 12:06
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 14, 2019
…estonly

Automatic update from web-platform-tests
Mark JSON module tests as tentative

See whatwg/html#4943 for context.

--

wpt-commits: bec7ffa28cc69fe8d8fb343fd9184d30ecce3070
wpt-pr: 19441


--HG--
rename : testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/invalid-content-type.html => testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/invalid-content-type.tentative.html
rename : testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/module.html => testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/module.tentative.html
rename : testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/non-object.any.js => testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/non-object.tentative.any.js
rename : testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/parse-error.html => testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/parse-error.tentative.html
rename : testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/utf8.html => testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/utf8.tentative.html
rename : testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/valid-content-type.html => testing/web-platform/tests/html/semantics/scripting-1/the-script-element/json-module/valid-content-type.tentative.html
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Oct 14, 2019
…estonly

Automatic update from web-platform-tests
Mark JSON module tests as tentative

See whatwg/html#4943 for context.

--

wpt-commits: bec7ffa28cc69fe8d8fb343fd9184d30ecce3070
wpt-pr: 19441
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 16, 2019
…estonly

Automatic update from web-platform-tests
Mark JSON module tests as tentative

See whatwg/html#4943 for context.

--

wpt-commits: bec7ffa28cc69fe8d8fb343fd9184d30ecce3070
wpt-pr: 19441

UltraBlame original commit: 4c1fd5ec1e57a33ef9e732ee1a87420825bfcb0a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 16, 2019
…estonly

Automatic update from web-platform-tests
Mark JSON module tests as tentative

See whatwg/html#4943 for context.

--

wpt-commits: bec7ffa28cc69fe8d8fb343fd9184d30ecce3070
wpt-pr: 19441

UltraBlame original commit: 4c1fd5ec1e57a33ef9e732ee1a87420825bfcb0a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 16, 2019
…estonly

Automatic update from web-platform-tests
Mark JSON module tests as tentative

See whatwg/html#4943 for context.

--

wpt-commits: bec7ffa28cc69fe8d8fb343fd9184d30ecce3070
wpt-pr: 19441

UltraBlame original commit: 4c1fd5ec1e57a33ef9e732ee1a87420825bfcb0a
@TimvdLippe TimvdLippe mentioned this pull request Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
removal/deprecation Removing or deprecating a feature
Development

Successfully merging this pull request may close these issues.

4 participants