dialog, autofocus: Do not enqueue elements with autofocus attribute i… #4918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nside a dialog element This fixes whatwg#4788
|
I know |
|
Feels a bit weird. Why would we add such special case to the platform |
|
@smaug---- are you aware that dialog and autofocus already have an interaction? See https://html.spec.whatwg.org/multipage/interactive-elements.html#dialog-focusing-steps |
|
@smaug---- |
|
That sounds nicer approach. |
|
Updated the PR for the new approach. |
domenic
approved these changes
Nov 7, 2019
domenic
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 7, 2019
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 29, 2019
…with <dialog>, a=testonly Automatic update from web-platform-tests hmtl: Add a test for an autofocus issue with <dialog> Follows whatwg/html#4918. -- wpt-commits: 64fff8f90cf94701f7631f84d54f882d846eca3a wpt-pr: 19151
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Nov 29, 2019
…with <dialog>, a=testonly Automatic update from web-platform-tests hmtl: Add a test for an autofocus issue with <dialog> Follows whatwg/html#4918. -- wpt-commits: 64fff8f90cf94701f7631f84d54f882d846eca3a wpt-pr: 19151
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 30, 2019
…with <dialog>, a=testonly Automatic update from web-platform-tests hmtl: Add a test for an autofocus issue with <dialog> Follows whatwg/html#4918. -- wpt-commits: 64fff8f90cf94701f7631f84d54f882d846eca3a wpt-pr: 19151 UltraBlame original commit: 77642112f19ce4ce97321b0b67fe4d301cf14ac5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 30, 2019
…with <dialog>, a=testonly Automatic update from web-platform-tests hmtl: Add a test for an autofocus issue with <dialog> Follows whatwg/html#4918. -- wpt-commits: 64fff8f90cf94701f7631f84d54f882d846eca3a wpt-pr: 19151 UltraBlame original commit: 77642112f19ce4ce97321b0b67fe4d301cf14ac5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 30, 2019
…with <dialog>, a=testonly Automatic update from web-platform-tests hmtl: Add a test for an autofocus issue with <dialog> Follows whatwg/html#4918. -- wpt-commits: 64fff8f90cf94701f7631f84d54f882d846eca3a wpt-pr: 19151 UltraBlame original commit: 77642112f19ce4ce97321b0b67fe4d301cf14ac5
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nside a dialog element
This fixes #4788
(See WHATWG Working Mode: Changes for more details.)
/interactive-elements.html ( diff )