-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make 'autofocus' a global attribute #4830
Conversation
- Add 'autofocus' to the global attribute list - Move 'autofocus' IDL attribute from HTMLButtonElement, HTMLInputElement, HTMLSelectElement, HTMLTextAreaElement to HTMLOrSVGElement This fixes whatwg#4563
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I guess it is pretty simple. I will push an additional sentence or two to tweak the main autofocus section to make it clearer in the non-normative introductory prose that it works on all elements. (The processing model already seems to work on all elements, although the processing model is also being fixed in #4763.)
The current PR moves the IDL attribute to |
Interesting question. In the past SVG folks have been excited about unifying where possible. In my opinion it is safe to tentatively assume they will want to do the same here, but we should open an issue and/or pull request to check. /cc @AmeliaBR |
I haven't heard any demand for Adding the IDL property to @tkent-google Are you able to make a PR on the SVG spec (to the Common/core attributes section you linked to, probably add it after |
ok, I filed an issue for SVG; w3c/svgwg#726 |
Made a WPT PR; web-platform-tests/wpt#18558 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable (and should be quite easy to tweak Gecko to have this behavior).
heads-up @whatwg/documentation |
…obal attribute, a=testonly Automatic update from web-platform-tests html, svg: Add a test for 'autofocus' as a global attribute (#18558) For whatwg/html#4830 -- wpt-commits: cfb69fe84608b80823905e9f257e2ef7700362bc wpt-pr: 18558
…obal attribute, a=testonly Automatic update from web-platform-tests html, svg: Add a test for 'autofocus' as a global attribute (#18558) For whatwg/html#4830 -- wpt-commits: cfb69fe84608b80823905e9f257e2ef7700362bc wpt-pr: 18558
…obal attribute, a=testonly Automatic update from web-platform-tests html, svg: Add a test for 'autofocus' as a global attribute (#18558) For whatwg/html#4830 -- wpt-commits: cfb69fe84608b80823905e9f257e2ef7700362bc wpt-pr: 18558 UltraBlame original commit: 9a87b8b6492b5506c938250f4d28c72332981181
…obal attribute, a=testonly Automatic update from web-platform-tests html, svg: Add a test for 'autofocus' as a global attribute (#18558) For whatwg/html#4830 -- wpt-commits: cfb69fe84608b80823905e9f257e2ef7700362bc wpt-pr: 18558 UltraBlame original commit: 9a87b8b6492b5506c938250f4d28c72332981181
…obal attribute, a=testonly Automatic update from web-platform-tests html, svg: Add a test for 'autofocus' as a global attribute (#18558) For whatwg/html#4830 -- wpt-commits: cfb69fe84608b80823905e9f257e2ef7700362bc wpt-pr: 18558 UltraBlame original commit: 9a87b8b6492b5506c938250f4d28c72332981181
HTMLSelectElement, HTMLTextAreaElement to HTMLOrSVGElement
This fixes #4563
(See WHATWG Working Mode: Changes for more details.)
/dom.html ( diff )
/form-control-infrastructure.html ( diff )
/form-elements.html ( diff )
/index.html ( diff )
/indices.html ( diff )
/input.html ( diff )
/interaction.html ( diff )
/interactive-elements.html ( diff )
/origin.html ( diff )