Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further tabIndex getter tweaks #4759

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Further tabIndex getter tweaks #4759

merged 1 commit into from
Aug 14, 2019

Conversation

domenic
Copy link
Member

@domenic domenic commented Jul 9, 2019

Further code inspection and test-writing revealed that SVG <a> elements
get a 0 default tabIndex in all engines, and <embed> and <object>
elements get a 0 default tabIndex in Blink and WebKit. These were
omitted in 15cf23a.


(See WHATWG Working Mode: Changes for more details.)


Honestly I merged #4754 prematurely. Given the rapidly-evolving state of my knowledge, and the refactoring I had to do for details which didn't get editorial review, I should not have merged that. My apologies. I can fix anything else wrong with #4754 here, as necessary.


/infrastructure.html ( diff )
/interaction.html ( diff )

Further code inspection and test-writing revealed that SVG <a> elements
get a 0 default tabIndex in all engines, and <object> elements get a 0
default tabIndex in Blink and WebKit. These were omitted in
15cf23a.
@domenic domenic merged commit 7ce0b47 into master Aug 14, 2019
@annevk annevk deleted the more-tabindex branch August 15, 2019 12:48
@rniwa
Copy link

rniwa commented Aug 16, 2019

I don't think was right change. Neither Firefox 67 or 68, and Safari 12 & 13 both uses -1 for the default tab index of object. Only Chrome uses the default tab index of 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants