-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not inherit text-transform (et al.) on form controls #4672
Conversation
This behavior has been implemented by many user agents and supported by web developers via various "CSS normalizing" libraries. Motivating issue: whatwg#1310 Tests: web-platform-tests/wpt#17152 Implementation in normalize.css: https://github.com/necolas/normalize.css Implementation in sanitize.css: https://github.com/csstools/sanitize.css Implementation in marx: https://github.com/mblode/marx Implementation in WebKit: https://github.com/WebKit/webkit/blob/89c28d471fae35f1788a0f857067896a10af8974/Source/WebCore/css/html.css#L360 Implementation in Chromium: https://chromium.googlesource.com/chromium/src/+/9b0f9c1/third_party/blink/renderer/core/html/resources/html.css#406
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updates look good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks all! If the implementation bugs are filed we can merge this.
Sounds good, I can file the bugs. Test results at https://wpt.fyi/results/html/rendering/non-replaced-elements/form-controls/resets.html?sha=3ac7cc537e For both WebKit and Blink, the failing test is missing For WebKit, there are failures in |
…rm`, a=testonly Automatic update from web-platform-tests HTML: tests for UA styles of `text-transform` For whatwg/html#4672. -- wpt-commits: 16ddb73a6251af3957efdbd6409b87a9c8cf6e50 wpt-pr: 17152
…rm`, a=testonly Automatic update from web-platform-tests HTML: tests for UA styles of `text-transform` For whatwg/html#4672. -- wpt-commits: 16ddb73a6251af3957efdbd6409b87a9c8cf6e50 wpt-pr: 17152
…rm`, a=testonly Automatic update from web-platform-tests HTML: tests for UA styles of `text-transform` For whatwg/html#4672. -- wpt-commits: 16ddb73a6251af3957efdbd6409b87a9c8cf6e50 wpt-pr: 17152 UltraBlame original commit: 4026d1a597d16b90ea5c62688f6cebd0db078ba6
…rm`, a=testonly Automatic update from web-platform-tests HTML: tests for UA styles of `text-transform` For whatwg/html#4672. -- wpt-commits: 16ddb73a6251af3957efdbd6409b87a9c8cf6e50 wpt-pr: 17152 UltraBlame original commit: 4026d1a597d16b90ea5c62688f6cebd0db078ba6
…rm`, a=testonly Automatic update from web-platform-tests HTML: tests for UA styles of `text-transform` For whatwg/html#4672. -- wpt-commits: 16ddb73a6251af3957efdbd6409b87a9c8cf6e50 wpt-pr: 17152 UltraBlame original commit: 4026d1a597d16b90ea5c62688f6cebd0db078ba6
text-transform
web-platform-tests/wpt#17152(See WHATWG Working Mode: Changes for more details.)
This behavior has been implemented by many user agents and supported by
web developers via various "CSS normalizing" libraries.
Motivating issue: #1310
Tests: web-platform-tests/wpt#17152
Implementation in normalize.css: https://github.com/necolas/normalize.css
Implementation in sanitize.css: https://github.com/csstools/sanitize.css
Implementation in marx: https://github.com/mblode/marx
Implementation in WebKit:
https://github.com/WebKit/webkit/blob/89c28d471fae35f1788a0f857067896a10af8974/Source/WebCore/css/html.css#L360
Implementation in Chromium:
https://chromium.googlesource.com/chromium/src/+/9b0f9c1/third_party/blink/renderer/core/html/resources/html.css#406
/rendering.html ( diff )