Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not inherit text-transform (et al.) on form controls #4672

Merged
merged 3 commits into from
Aug 29, 2019

Conversation

jugglinmike
Copy link
Contributor

@jugglinmike jugglinmike commented Jun 3, 2019

@jugglinmike
Copy link
Contributor Author

jugglinmike commented Jun 3, 2019

This should resolve gh-1310 and gh-4676

source Show resolved Hide resolved
@zcorpan zcorpan changed the title Do not inherit text-transform on form controls Do not inherit text-transform (et al.) on form controls Aug 22, 2019
@zcorpan zcorpan requested a review from emilio August 27, 2019 11:31
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than that.

source Show resolved Hide resolved
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates look good :)

annevk pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 29, 2019
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all! If the implementation bugs are filed we can merge this.

@zcorpan
Copy link
Member

zcorpan commented Aug 29, 2019

Sounds good, I can file the bugs.

Test results at https://wpt.fyi/results/html/rendering/non-replaced-elements/form-controls/resets.html?sha=3ac7cc537e

For both WebKit and Blink, the failing test is missing table { text-indent: initial } which was already in the spec before this change.

For WebKit, there are failures in line-height. See w3c/csswg-drafts#4249

@zcorpan zcorpan merged commit b9997b7 into whatwg:master Aug 29, 2019
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 3, 2019
…rm`, a=testonly

Automatic update from web-platform-tests
HTML: tests for UA styles of `text-transform`

For whatwg/html#4672.
--

wpt-commits: 16ddb73a6251af3957efdbd6409b87a9c8cf6e50
wpt-pr: 17152
dbaron pushed a commit to dbaron/gecko that referenced this pull request Sep 4, 2019
…rm`, a=testonly

Automatic update from web-platform-tests
HTML: tests for UA styles of `text-transform`

For whatwg/html#4672.
--

wpt-commits: 16ddb73a6251af3957efdbd6409b87a9c8cf6e50
wpt-pr: 17152
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
…rm`, a=testonly

Automatic update from web-platform-tests
HTML: tests for UA styles of `text-transform`

For whatwg/html#4672.
--

wpt-commits: 16ddb73a6251af3957efdbd6409b87a9c8cf6e50
wpt-pr: 17152

UltraBlame original commit: 4026d1a597d16b90ea5c62688f6cebd0db078ba6
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
…rm`, a=testonly

Automatic update from web-platform-tests
HTML: tests for UA styles of `text-transform`

For whatwg/html#4672.
--

wpt-commits: 16ddb73a6251af3957efdbd6409b87a9c8cf6e50
wpt-pr: 17152

UltraBlame original commit: 4026d1a597d16b90ea5c62688f6cebd0db078ba6
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
…rm`, a=testonly

Automatic update from web-platform-tests
HTML: tests for UA styles of `text-transform`

For whatwg/html#4672.
--

wpt-commits: 16ddb73a6251af3957efdbd6409b87a9c8cf6e50
wpt-pr: 17152

UltraBlame original commit: 4026d1a597d16b90ea5c62688f6cebd0db078ba6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants