Add a nonintuitive disconnectedCallback example #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
added
the
topic: custom elements
annevk
changed the title
Supersedes and closes #4127. Closes WICG/webcomponents#760.
annevk
force-pushed
the
annevk/disconnectedCallback
branch
from
e92f3c8 to
7158112
Compare
rniwa
reviewed
Dec 13, 2018
source
Outdated
| } | ||
| customElements.define("c-child", CChild); | ||
|
|
||
| const container = document.createElement("div"); |
There was a problem hiding this comment.
A perhaps a more straight forward way to construct this tree would be:
const parent = new CParent;
const child = new CChild;
CParent.append(child)
rniwa
reviewed
Dec 13, 2018
source
Outdated
| <div class="example"> | ||
| <p>An element's <code data-x="">connectedCallback</code> can be queued before the element is | ||
| disconnected, but as the callback queue is still processed, it results in a <code | ||
| data-x="">connectedCallback</code> for an element that is no longer connected:</p> |
There was a problem hiding this comment.
I think we want to add some note saying that mutating DOM tree inside custom elements reactions is bad for this reason.
There was a problem hiding this comment.
+1. We could even consider adding it to https://html.spec.whatwg.org/multipage/custom-elements.html#custom-element-conformance and renaming that section to be about more than just constructors.
|
Addressed all I think. |
domenic
approved these changes
Dec 16, 2018
| const parent = new CParent(), | ||
| child = new CChild(); | ||
| parent.append(child); | ||
| document.body.appendChild(parent); |
There was a problem hiding this comment.
Slightly weird to use .append() then .appendChild() together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes and closes #4127. Closes WICG/webcomponents#760.
/acknowledgements.html ( diff )
/custom-elements.html ( diff )
/index.html ( diff )