Use DOM's "replace all" primitive in document.open() #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it clearer what is expected with respect to mutation observers. This also removes the mutation events comment, because as far as I can tell there's no way to observe whether they are fired if all event listeners are removed per the requirement two steps prior.
|
Since mutation events bubble, you could observe them by adding a listener to |
annevk
added
the
do not merge yet
|
That's very true, thanks! |
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 27, 2018
annevk
removed
the
do not merge yet
|
I wrote tests and I have a follow-up issue at whatwg/dom#640. It still seems nice to start using "replace all" here, just to make it easier to find all places that use that primitive. |
domenic
approved these changes
Apr 30, 2018
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 30, 2018
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 2, 2018
…s, a=testonly Automatic update from web-platform-testsHTML: document.open() and mutation events See whatwg/html#3598. -- wpt-commits: e4b690a768b15c0b2aab558e97454385ec7164e1 wpt-pr: 10680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it clearer what is expected with respect to mutation observers.
This also removes the mutation events comment, because as far as I can tell there's no way to observe whether they are fired if all event listeners are removed per the requirement two steps prior.
/dynamic-markup-insertion.html ( diff )