Define base appearance for <select> #10629
Conversation
| @@ -53096,6 +53110,10 @@ interface <dfn interface>HTMLButtonElement</dfn> : <span>HTMLElement</span> { | |||
| <li><p>If <var>element</var>'s <span>node document</span> is not <span>fully active</span>, then | |||
| return.</p></li> | |||
|
|
|||
| <li><p>If <var>element</var>'s <span>parent</span> is a <code>select</code> element, then | |||
| <span>show the picker, if applicable</span> given <var>element</var>'s <span>parent</span> and | |||
| return.</p></li> | |||
There was a problem hiding this comment.
Are we sure the activation behavior is on the button element and not the select element?
| <ol> | ||
| <li> | ||
| <p>For each <var>ancestor</var> of <var>option</var>'s <span | ||
| data-x="ancestor">ancestors</span>:</p> |
There was a problem hiding this comment.
I guess the order technically doesn't matter, but seems good to specify still in case of future changes.
| <ol> | ||
| <li> | ||
| <p>For each <var>ancestor</var> of <var>element</var>'s <span | ||
| data-x="ancestor">ancestors</span>:</p> |
There was a problem hiding this comment.
Here the order seems like it actually matters.
|
|
||
| <p>Whenever an <code>option</code> <var>option</var>'s <span | ||
| data-x="concept-option-selectedness">selectedness</span> is set to true, run <span>maybe clone | ||
| option into select button</span> given <var>option</var>.</p> |
There was a problem hiding this comment.
This seems weird. Normally changing members doesn't have weird side effects like this.
|
|
||
| <p>When a <code>select</code> is being rendered as a <span>drop-down box</span> with a <span>base | ||
| appearance</span>, it is expected to render as if it has the following <span>shadow | ||
| root</span>:</p> |
There was a problem hiding this comment.
You can't define a shadow root in terms of an HTML syntax fragment.
| HTML:</p> | ||
|
|
||
| <!-- TODO is it OK for me to use <ul>, <li>, and <p> like this even though it isn't an | ||
| algorithm? --> |
There was a problem hiding this comment.
I think the problem is really with how you define the shadow root. If you do that differently this will be different too. But you can use lists outside of algorithms for sure.
|
|
||
| <p>The <span>implicit anchor element</span> of the <span>select popover</span> element is the | ||
| <code>select</code> element shadow host of the shadow host in which <span>select popover</span> | ||
| resides.</p> |
|
|
||
| <p class="note">Without <span>delegates focus</span> set to true, the <code>select</code> itself | ||
| would receive focus instead of the <code>button</code> which is slotted into the <span>select | ||
| button slot</span>.</p> |
There was a problem hiding this comment.
Is this still accurate given yesterday's WHATNOT discussion?
|
|
||
| <li><p>Set <var>select</var>'s <span>select popover slot</span>'s <span>manually assigned | ||
| nodes</span> to <var>otherChildren</var>.</p></li> | ||
| </ol> |
There was a problem hiding this comment.
Why can't we describe this more similarly to the details element?
This PR defines the base appearance except for the UA stylesheet for customizable select as proposed in #9799
Base appearance is being defined in CSS here: w3c/csswg-drafts#10691
(See WHATWG Working Mode: Changes for more details.)
/form-elements.html ( diff )
/infrastructure.html ( diff )
/references.html ( diff )
/rendering.html ( diff )